Change in openbsc[master]: Make alert notifications vty configurable per ESME

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

osmith gerrit-no-reply at lists.osmocom.org
Tue Feb 12 10:41:57 UTC 2019


osmith has posted comments on this change. ( https://gerrit.osmocom.org/12601 )

Change subject: Make alert notifications vty configurable per ESME
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/#/c/12601/1/openbsc/src/libmsc/smpp_openbsc.c
File openbsc/src/libmsc/smpp_openbsc.c:

https://gerrit.osmocom.org/#/c/12601/1/openbsc/src/libmsc/smpp_openbsc.c@291
PS1, Line 291: 		} else {
> I don't understand how it can be NULL, which is because I tried but failed to understand llist_for_each_entry()

It iterates over "smsc->esme_list", and puts each entry in "esme" as it runs the code in {} on each iteration.

Without looking much into the code that initializes smsc->esme_list, it seems that the whole osmo_esme struct gets zero-allocated. So esme->acl, like everything else in esme is NULL by default. At some later point, memory would get allocated for a full "struct osmo_smpp_acl" datatype (which is the datatype of esme->acl, see smpp_smsc.h), and the pointer to that new memory region would be placed in esme->acl. Then you are able to access it with esme->acl->foobar.

Now this alert_all_esme() function may run before or after esme->acl has been filled out, which is why we must check for it at that point.

(Again, I am not familiar with the code, but that's my understanding of it.)

> I feel a bit demoralised now that I patched a crash causing bug in there :(((

To be fair, this wasn't really obvious or otherwise it would have been catched in the review.



-- 
To view, visit https://gerrit.osmocom.org/12601
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: openbsc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2b52f2778b24eebc82b2e5e2fb3c2250b1f9e5b0
Gerrit-Change-Number: 12601
Gerrit-PatchSet: 1
Gerrit-Owner: Keith Whyte <keith at rhizomatica.org>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Keith Whyte <keith at rhizomatica.org>
Gerrit-CC: osmith <osmith at sysmocom.de>
Gerrit-Comment-Date: Tue, 12 Feb 2019 10:41:57 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190212/77ee74bd/attachment.htm>


More information about the gerrit-log mailing list