This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
osmith gerrit-no-reply at lists.osmocom.orgosmith has posted comments on this change. ( https://gerrit.osmocom.org/12601 ) Change subject: Make alert notifications vty configurable per ESME ...................................................................... Patch Set 1: (1 comment) https://gerrit.osmocom.org/#/c/12601/1/openbsc/src/libmsc/smpp_openbsc.c File openbsc/src/libmsc/smpp_openbsc.c: https://gerrit.osmocom.org/#/c/12601/1/openbsc/src/libmsc/smpp_openbsc.c@291 PS1, Line 291: } else { > Would it not also crash then here in the case that esme->acl == false (it's a pointer, so I assume you mean == NULL) I am not familiar with the openbsc codebase. But from what I can tell, it would not crash here, because smpp_tx_alert() does not try to access esme->acl: https://git.osmocom.org/openbsc/tree/openbsc/src/libmsc/smpp_smsc.c?id=ed8815e723b41e9800f14c67bccd34e51a06beb6#n629 -- To view, visit https://gerrit.osmocom.org/12601 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: openbsc Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2b52f2778b24eebc82b2e5e2fb3c2250b1f9e5b0 Gerrit-Change-Number: 12601 Gerrit-PatchSet: 1 Gerrit-Owner: Keith Whyte <keith at rhizomatica.org> Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Keith Whyte <keith at rhizomatica.org> Gerrit-CC: osmith <osmith at sysmocom.de> Gerrit-Comment-Date: Mon, 11 Feb 2019 15:20:13 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190211/1062da57/attachment.htm>