Change in osmo-sysmon[master]: Add OpenVPN probe

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Max gerrit-no-reply at lists.osmocom.org
Mon Feb 11 15:03:51 UTC 2019


Max has posted comments on this change. ( https://gerrit.osmocom.org/12763 )

Change subject: Add OpenVPN probe
......................................................................


Patch Set 7:

(1 comment)

So far there's only one probe which uses osmocom event loop. That's why I've opted to make it optional.

https://gerrit.osmocom.org/#/c/12763/7/src/osysmon_main.c
File src/osysmon_main.c:

https://gerrit.osmocom.org/#/c/12763/7/src/osysmon_main.c@252
PS7, Line 252: 		sleep(1);
> why not always polling osmocom event loop with a timeout of 1 second

That would require setting up 1 second timer and adding it to event loop which seems more complex than optionally calling to osmo_select_main() only when the probe using it is enabled.



-- 
To view, visit https://gerrit.osmocom.org/12763
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-sysmon
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4493e19b9a09dcebd289457eacd1719f7f8cc31c
Gerrit-Change-Number: 12763
Gerrit-PatchSet: 7
Gerrit-Owner: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Comment-Date: Mon, 11 Feb 2019 15:03:51 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190211/5dd4ae7e/attachment.htm>


More information about the gerrit-log mailing list