This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Max gerrit-no-reply at lists.osmocom.orgMax has posted comments on this change. ( https://gerrit.osmocom.org/12761 ) Change subject: Introduce generic host config and related helpers ...................................................................... Patch Set 6: (1 comment) I can change the macro the way you propose but it seems rather pointless to me: we're trying to prevent theoretical memleak in an unwritten code which have to be written in particular (and wrong) way for it to happen at all. https://gerrit.osmocom.org/#/c/12761/6/src/simple_ctrl.c File src/simple_ctrl.c: https://gerrit.osmocom.org/#/c/12761/6/src/simple_ctrl.c@42 PS6, Line 42: fprintf(stderr, "CTRL %s error: " fmt, make_authority(sch, &sch->cfg), ##args) > memleak of make_authority. At least until you free sch. […] The ERR part in macro name refers to "error" - this macro will be called only when we have some errors. Keeping sch despite of the permanent error associated with it is plain wrong. No current user of this code does that. -- To view, visit https://gerrit.osmocom.org/12761 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sysmon Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie321655a92cdbefbfaa056ac0d583397c83beccb Gerrit-Change-Number: 12761 Gerrit-PatchSet: 6 Gerrit-Owner: Max <msuraev at sysmocom.de> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Max <msuraev at sysmocom.de> Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de> Gerrit-Comment-Date: Mon, 11 Feb 2019 14:53:05 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190211/6549d4cb/attachment.htm>