Change in osmo-msc[master]: libmsc/gsm_09_11.c: implement guard timer for NCSS sessions

[Vadim Yanitskiy]

Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/11992 )

Change subject: libmsc/gsm_09_11.c: implement guard timer for NCSS sessions
......................................................................


Patch Set 10:

(4 comments)

https://gerrit.osmocom.org/#/c/11992/10//COMMIT_MSG
Commit Message:

https://gerrit.osmocom.org/#/c/11992/10//COMMIT_MSG@9
PS10, Line 9: ESME
> EUSE?
Ahh, sure. Thanks!


https://gerrit.osmocom.org/#/c/11992/10/include/osmocom/msc/transaction.h
File include/osmocom/msc/transaction.h:

https://gerrit.osmocom.org/#/c/11992/10/include/osmocom/msc/transaction.h@89
PS10, Line 89: watchdog;
> in the CC sub-struct above we call it "timer_guard". […]
Done.


https://gerrit.osmocom.org/#/c/11992/10/src/libmsc/gsm_09_11.c
File src/libmsc/gsm_09_11.c:

https://gerrit.osmocom.org/#/c/11992/10/src/libmsc/gsm_09_11.c@153
PS10, Line 153: 	if (conn->network->ncss_guard_timeout > 0) {
> This seems like possible race condition if you disable the ncss_guard_timeout from VTY while USSD se […]
Hmm, I am not sure if we really need to care about changing the configuration at run-time...


https://gerrit.osmocom.org/#/c/11992/10/src/libmsc/gsm_09_11.c@156
PS10, Line 156: 	}
> else if (osmo_timer_pending(&trans->ss.watchdog)) { […]
This solution wouldn't help if the timer is disabled from the VTY, but there is no any activity on a given session. A proper solution would be to reschedule all NCSS timers from the VTY command handler...



-- 
To view, visit https://gerrit.osmocom.org/11992
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Icf4d87c45e90324764073e8230e0fb9cb96dd9cb
Gerrit-Change-Number: 11992
Gerrit-PatchSet: 10
Gerrit-Owner: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-Reviewer: daniel <dwillmann at sysmocom.de>
Gerrit-CC: Stefan Sperling <stsp at stsp.name>
Gerrit-Comment-Date: Sun, 10 Feb 2019 13:07:18 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190210/8bda37b2/attachment.htm>