This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Vadim Yanitskiy gerrit-no-reply at lists.osmocom.orgVadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/12860 ) Change subject: GSUP: add inter-MSC handover related msgs and IEs ...................................................................... Patch Set 2: (6 comments) https://gerrit.osmocom.org/#/c/12860/2/include/osmocom/gsm/gsup.h File include/osmocom/gsm/gsup.h: https://gerrit.osmocom.org/#/c/12860/2/include/osmocom/gsm/gsup.h@196 PS2, Line 196: OSMO_GSUP_MSGT_E_CLOSE As far as I can see, this comes from TCAP. And we already have the session state IE, why not to extend it with ABORT? https://gerrit.osmocom.org/#/c/12860/2/include/osmocom/gsm/gsup.h@338 PS2, Line 338: an_apdu I would use a pointer here. The osmo_gsup_message is already quite big... https://gerrit.osmocom.org/#/c/12860/2/include/osmocom/gsm/gsup.h@341 PS2, Line 341: cause_sm Does SM mean "Short Message"? If yes, we already have "sm_rp_cause". https://gerrit.osmocom.org/#/c/12860/2/include/osmocom/gsm/gsup_handover.h File include/osmocom/gsm/gsup_handover.h: https://gerrit.osmocom.org/#/c/12860/2/include/osmocom/gsm/gsup_handover.h@19 PS2, Line 19: uint8_t const? https://gerrit.osmocom.org/#/c/12860/2/src/gsm/gsup.c File src/gsm/gsup.c: https://gerrit.osmocom.org/#/c/12860/2/src/gsm/gsup.c@789 PS2, Line 789: u8 = gsup_msg->cause_bssap One wouldn't be able to encode GSM0808_CAUSE_RADIO_INTERFACE_MESSAGE_FAILURE == 0x00 this way. This is why I was talking about pointers. https://gerrit.osmocom.org/#/c/12860/2/tests/gsup/gsup_test.c File tests/gsup/gsup_test.c: https://gerrit.osmocom.org/#/c/12860/2/tests/gsup/gsup_test.c@338 PS2, Line 338: [] We don't have this space usually. -- To view, visit https://gerrit.osmocom.org/12860 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic00b0601eacff6d72927cea51767801142ee75db Gerrit-Change-Number: 12860 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith at sysmocom.de> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Max <msuraev at sysmocom.de> Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de> Gerrit-Reviewer: Vadim Yanitskiy <axilirator at gmail.com> Gerrit-Reviewer: daniel <dwillmann at sysmocom.de> Gerrit-Reviewer: osmith <osmith at sysmocom.de> Gerrit-Comment-Date: Sat, 09 Feb 2019 08:39:40 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190209/c9943582/attachment.htm>