This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Pau Espin Pedrol gerrit-no-reply at lists.osmocom.orgPau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/12863 ) Change subject: OML: Return attributes in ACK/NACK messages ...................................................................... Patch Set 1: Code-Review-1 (1 comment) https://gerrit.osmocom.org/#/c/12863/1/src/common/oml.c File src/common/oml.c: https://gerrit.osmocom.org/#/c/12863/1/src/common/oml.c@448 PS1, Line 448: msgb_tv_put(msg, NM_ATT_NACK_CAUSES, cause); Don't you need to update omh->length after putting more info? Since you are not longer calling oml_send_msg anymore, which does the update: omh->length = msgb_l3len(msg); -- To view, visit https://gerrit.osmocom.org/12863 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifb305fe75f8305bb04872f26492b8b1bb8c27f49 Gerrit-Change-Number: 12863 Gerrit-PatchSet: 1 Gerrit-Owner: Harald Welte <laforge at gnumonks.org> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de> Gerrit-Comment-Date: Fri, 08 Feb 2019 23:07:06 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: Yes -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190208/bbdd8f53/attachment.htm>