Change in libosmocore[master]: gsm/gsm0480: introduce gsm0480_create_release_complete()

[Vadim Yanitskiy]

Vadim Yanitskiy has submitted this change and it was merged. ( https://gerrit.osmocom.org/12839 )

Change subject: gsm/gsm0480: introduce gsm0480_create_release_complete()
......................................................................

gsm/gsm0480: introduce gsm0480_create_release_complete()

In OsmoMSC, it's required to be able to specify a particular GSM 04.07
transaction ID for GSM 04.80 Release complete message instead of the
hard-coded value, that is used gsm0480_create_ussd_release_complete().

Let's finally deprecate gsm0480_create_ussd_release_complete(), and
introduce a new function without USSD prefix, as this message
is also used in other "structured" supplementary services.

Change-Id: Ie3ac85fcef90a5e532334ba3482804d5305c88d7
---
M include/osmocom/gsm/gsm0480.h
M src/gsm/gsm0480.c
M src/gsm/libosmogsm.map
3 files changed, 26 insertions(+), 1 deletion(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/include/osmocom/gsm/gsm0480.h b/include/osmocom/gsm/gsm0480.h
index 827464e..4200189 100644
--- a/include/osmocom/gsm/gsm0480.h
+++ b/include/osmocom/gsm/gsm0480.h
@@ -117,7 +117,9 @@
 struct msgb *gsm0480_create_unstructuredSS_Notify(int alertPattern, const char *text);
 struct msgb *gsm0480_create_notifySS(const char *text);
 struct msgb *gsm0480_create_ussd_notify(int level, const char *text);
-struct msgb *gsm0480_create_ussd_release_complete(void);
+struct msgb *gsm0480_create_ussd_release_complete(void)
+	OSMO_DEPRECATED("Use gsm0480_create_release_complete() instead.");
+struct msgb *gsm0480_create_release_complete(uint8_t trans_id);
 
 int gsm0480_wrap_invoke(struct msgb *msg, int op, int link_id);
 int gsm0480_wrap_facility(struct msgb *msg);
diff --git a/src/gsm/gsm0480.c b/src/gsm/gsm0480.c
index b5c9844..9f546cc 100644
--- a/src/gsm/gsm0480.c
+++ b/src/gsm/gsm0480.c
@@ -921,6 +921,7 @@
 	return msg;
 }
 
+/*! Deprecated, use gsm0480_create_release_complete() instead. */
 struct msgb *gsm0480_create_ussd_release_complete(void)
 {
 	struct msgb *msg;
@@ -936,3 +937,23 @@
 
 	return msg;
 }
+
+/*! Create a GSM 04.80 Release complete (see 2.5) message, prefixed
+ *  by GSM 04.08 L3 header with a given transaction ID.
+ * \param[in] trans_id  GSM 04.07 transaction identifier (and TI flag)
+ * \return  message buffer containing the Release complete message
+ */
+struct msgb *gsm0480_create_release_complete(uint8_t trans_id)
+{
+	struct msgb *msg;
+
+	msg = gsm0480_msgb_alloc_name("TS 04.80 USSD REL COMPL");
+	if (!msg)
+		return NULL;
+
+	/* Push the L3 header */
+	gsm48_push_l3hdr_tid(msg, GSM48_PDISC_NC_SS,
+			     trans_id, GSM0480_MTYPE_RELEASE_COMPLETE);
+
+	return msg;
+}
diff --git a/src/gsm/libosmogsm.map b/src/gsm/libosmogsm.map
index 602c7a6..ae7c0a1 100644
--- a/src/gsm/libosmogsm.map
+++ b/src/gsm/libosmogsm.map
@@ -89,6 +89,8 @@
 gsm0480_create_ussd_resp;
 gsm0480_create_ussd_notify;
 gsm0480_create_ussd_release_complete;
+gsm0480_create_release_complete;
+
 gsm0480_extract_ie_by_tag;
 gsm0480_parse_facility_ie;
 gsm0480_decode_ussd_request;

-- 
To view, visit https://gerrit.osmocom.org/12839
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie3ac85fcef90a5e532334ba3482804d5305c88d7
Gerrit-Change-Number: 12839
Gerrit-PatchSet: 3
Gerrit-Owner: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Vadim Yanitskiy <axilirator at gmail.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190208/6c5ff5e1/attachment.htm>