This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Vadim Yanitskiy gerrit-no-reply at lists.osmocom.orgVadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/12839 ) Change subject: gsm/gsm0480: introduce gsm0480_create_release_complete[_cause]() API ...................................................................... Patch Set 1: Hi Harald, > If you're introducing a new API function, I would consider it "most > clean" if one were to pass a "struct release_cause { location; > cause; }" kind of struct as a "const *" pointer to a function. If > that pointer is NULL, then the optional element is not encoded. If > it's non-null the optional element is encoded as per the elements > in that struct. hmm, yes. But since you're suggesting to introduce a new struct, I think we need to introduce the new API for Cause IE. The current gsm48_encode_cause() is mixed up with gsm_mncc_cause struct, and I really don't like this... -- To view, visit https://gerrit.osmocom.org/12839 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie3ac85fcef90a5e532334ba3482804d5305c88d7 Gerrit-Change-Number: 12839 Gerrit-PatchSet: 1 Gerrit-Owner: Vadim Yanitskiy <axilirator at gmail.com> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Vadim Yanitskiy <axilirator at gmail.com> Gerrit-CC: Harald Welte <laforge at gnumonks.org> Gerrit-Comment-Date: Wed, 06 Feb 2019 08:23:59 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190206/869f878e/attachment.htm>