Change in osmo-sysmon[master]: Install signal handlers before processing config

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Harald Welte gerrit-no-reply at lists.osmocom.org
Wed Feb 6 08:10:05 UTC 2019


Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/12758 )

Change subject: Install signal handlers before processing config
......................................................................

Install signal handlers before processing config

It's easier to troubleshoot vty-related issues when we can send signals
to obtain talloc report.

Change-Id: I6dd1ad55a227db08595d844008be86f648fa92c1
---
M src/osysmon_main.c
1 file changed, 4 insertions(+), 4 deletions(-)

Approvals:
  Harald Welte: Looks good to me, approved
  osmith: Looks good to me, but someone else must approve
  Jenkins Builder: Verified



diff --git a/src/osysmon_main.c b/src/osysmon_main.c
index eb4f50b..91d5039 100644
--- a/src/osysmon_main.c
+++ b/src/osysmon_main.c
@@ -210,6 +210,10 @@
 	ping_init = osysmon_ping_init();
 	osysmon_file_init();
 
+	signal(SIGUSR1, &signal_handler);
+	signal(SIGUSR2, &signal_handler);
+	osmo_init_ignore_signals();
+
 	rc = vty_read_config_file(cmdline_opts.config_file, NULL);
 	if (rc < 0) {
 		fprintf(stderr, "Failed to parse the config file %s\n",
@@ -217,10 +221,6 @@
 		exit(2);
 	}
 
-	signal(SIGUSR1, &signal_handler);
-	signal(SIGUSR2, &signal_handler);
-	osmo_init_ignore_signals();
-
 	if (cmdline_opts.daemonize) {
 		rc = osmo_daemonize();
 		if (rc < 0) {

-- 
To view, visit https://gerrit.osmocom.org/12758
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-sysmon
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I6dd1ad55a227db08595d844008be86f648fa92c1
Gerrit-Change-Number: 12758
Gerrit-PatchSet: 2
Gerrit-Owner: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: daniel <dwillmann at sysmocom.de>
Gerrit-Reviewer: osmith <osmith at sysmocom.de>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190206/21ee4617/attachment.htm>


More information about the gerrit-log mailing list