Change in osmo-msc[master]: Move enum definition to header file

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Harald Welte gerrit-no-reply at lists.osmocom.org
Tue Feb 5 16:24:29 UTC 2019


Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/12598 )

Change subject: Move enum definition to header file
......................................................................


Patch Set 1: Code-Review+2

(1 comment)

https://gerrit.osmocom.org/#/c/12598/1/src/libmsc/smpp_smsc.h
File src/libmsc/smpp_smsc.h:

https://gerrit.osmocom.org/#/c/12598/1/src/libmsc/smpp_smsc.h@22
PS1, Line 22: enum esme_bind {
> I'd sort of like the osmo_* prefix here, but then it's missing in esme_read_state as well... […]
we never put osmo_ prefixes into any symbols/type-names unless they're part of an installed library.  libmsc.a is never installed and as such an internal part of osmo-msc.  Therefore an osmo* prefix would actually be wrong.



-- 
To view, visit https://gerrit.osmocom.org/12598
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I71b2512894ec2a71a25f35f07ff4308035d951f9
Gerrit-Change-Number: 12598
Gerrit-PatchSet: 1
Gerrit-Owner: Keith Whyte <keith at rhizomatica.org>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-CC: daniel <dwillmann at sysmocom.de>
Gerrit-Comment-Date: Tue, 05 Feb 2019 16:24:29 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190205/5de15b1b/attachment.htm>


More information about the gerrit-log mailing list