Change in libosmo-abis[master]: Log peer's port in accept callback

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Max gerrit-no-reply at lists.osmocom.org
Tue Feb 5 16:03:21 UTC 2019


Max has submitted this change and it was merged. ( https://gerrit.osmocom.org/12654 )

Change subject: Log peer's port in accept callback
......................................................................

Log peer's port in accept callback

* log port from which we accept() the connection in addition to address
* use macro helper for logging

Change-Id: I186974dae1819af8c92f9ea9eeb966ec7c9c9f55
---
M src/input/ipa.c
1 file changed, 2 insertions(+), 2 deletions(-)

Approvals:
  Jenkins Builder: Verified
  Vadim Yanitskiy: Looks good to me, but someone else must approve
  osmith: Looks good to me, approved



diff --git a/src/input/ipa.c b/src/input/ipa.c
index 9853ffa..e41ec42 100644
--- a/src/input/ipa.c
+++ b/src/input/ipa.c
@@ -266,8 +266,8 @@
 			link->addr = talloc_strdup(link, ipbuf);
 	}
 
-	LOGP(DLINP, LOGL_NOTICE, "accept()ed new link from %s to port %u\n",
-		inet_ntoa(sa.sin_addr), link->port);
+	LOGIPA(link, LOGL_NOTICE, "accept()ed new link from %s:%u\n",
+		inet_ntoa(sa.sin_addr), ntohs(sa.sin_port));
 
 	ret = link->accept_cb(link, fd);
 	if (ret < 0) {

-- 
To view, visit https://gerrit.osmocom.org/12654
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-abis
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I186974dae1819af8c92f9ea9eeb966ec7c9c9f55
Gerrit-Change-Number: 12654
Gerrit-PatchSet: 2
Gerrit-Owner: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-Reviewer: osmith <osmith at sysmocom.de>
Gerrit-CC: Harald Welte <laforge at gnumonks.org>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190205/3f8db59d/attachment.htm>


More information about the gerrit-log mailing list