Change in osmo-bsc[master]: bsc_vty: add features to disable specific lchans via vty

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Mon Feb 4 23:36:30 UTC 2019


Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/12624 )

Change subject: bsc_vty: add features to disable specific lchans via vty
......................................................................


Patch Set 7: Code-Review-1

(2 comments)

once this NULL deref is fixed, go ahead and give yourself a +2 IMO

https://gerrit.osmocom.org/#/c/12624/7/src/osmo-bsc/bsc_vty.c
File src/osmo-bsc/bsc_vty.c:

https://gerrit.osmocom.org/#/c/12624/7/src/osmo-bsc/bsc_vty.c@4810
PS7, Line 4810: 		if (lchan->fi->state == LCHAN_ST_UNUSED)
vadim is right. Not all lchan->fi are actually allocated. This would become a NULL deref segfault when passing too large lchan nr. Sorry for missing this before.


https://gerrit.osmocom.org/#/c/12624/7/src/osmo-bsc/bsc_vty.c@4815
PS7, Line 4815: 				osmo_fsm_state_name(lchan->fi->fsm, lchan->fi->state),
(this one could be osmo_fsm_inst_state_name(lchan->fi); but not important)



-- 
To view, visit https://gerrit.osmocom.org/12624
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I397e68e26d6a1727890353fa34f4897b54795866
Gerrit-Change-Number: 12624
Gerrit-PatchSet: 7
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: dexter <pmaier at sysmocom.de>
Gerrit-CC: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-Comment-Date: Mon, 04 Feb 2019 23:36:30 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190204/ecc9e0fd/attachment.htm>


More information about the gerrit-log mailing list