Change in libosmocore[master]: bitvec: Add bitvec_tailroom_bits() function

[Harald Welte]

Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/12816 )

Change subject: bitvec: Add bitvec_tailroom_bits() function
......................................................................


Patch Set 2:

(1 comment)

https://gerrit.osmocom.org/#/c/12816/2/tests/bitvec/bitvec_test.c
File tests/bitvec/bitvec_test.c:

https://gerrit.osmocom.org/#/c/12816/2/tests/bitvec/bitvec_test.c@219
PS2, Line 219: 	for (i = 0; i < 8; i++) {
> Why only 8? Why not go over entire vector so both corner cases (no bits set vs all bits set) are cov […]
It didn't occur to me that "all bits set" could also be a problematic case, if we had already established that it works for one byte/8bits. Everything from there is just a logical progression.



-- 
To view, visit https://gerrit.osmocom.org/12816
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8980a6b6d1973b67a2d9ad411c878d956fb428d1
Gerrit-Change-Number: 12816
Gerrit-PatchSet: 2
Gerrit-Owner: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-CC: Max <msuraev at sysmocom.de>
Gerrit-Comment-Date: Mon, 04 Feb 2019 19:56:39 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190204/531c6e47/attachment.htm>