Change in osmo-asf4-dfu[sysmoOCTSIM]: change LED and switch to sysmoOCTSIM board

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Harald Welte gerrit-no-reply at lists.osmocom.org
Sun Feb 3 22:49:15 UTC 2019


Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/12789 )

Change subject: change LED and switch to sysmoOCTSIM board
......................................................................


Patch Set 1: Code-Review+1

(1 comment)

https://gerrit.osmocom.org/#/c/12789/1/atmel_start_pins.h
File atmel_start_pins.h:

https://gerrit.osmocom.org/#/c/12789/1/atmel_start_pins.h@30
PS1, Line 30: /** LED pin to indicate system state (pull high to switch on) */
those kind of board-specific #defines should be moved to a "board.h" file which could then be in a board-specific sub-directory.  You could start with having two of them, one for the evaluation board, and one for symsoOCTSIM.  The Makefile could then specify the include path of the board we're currently building for.



-- 
To view, visit https://gerrit.osmocom.org/12789
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-asf4-dfu
Gerrit-Branch: sysmoOCTSIM
Gerrit-MessageType: comment
Gerrit-Change-Id: I481d96a284240310b634f6dc0806d4a1972cd3b9
Gerrit-Change-Number: 12789
Gerrit-PatchSet: 1
Gerrit-Owner: Kévin Redon <kredon at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Comment-Date: Sun, 03 Feb 2019 22:49:15 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190203/5380e404/attachment.htm>


More information about the gerrit-log mailing list