Change in osmocom-bb[master]: common/sim.c: get rid of unused 'payload' pointer

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Vadim Yanitskiy gerrit-no-reply at lists.osmocom.org
Sun Feb 3 11:26:41 UTC 2019


Vadim Yanitskiy has submitted this change and it was merged. ( https://gerrit.osmocom.org/12785 )

Change subject: common/sim.c: get rid of unused 'payload' pointer
......................................................................

common/sim.c: get rid of unused 'payload' pointer

This change fixes the following compiler warning:

  sim.c: In function ‘gsm_sim_reply’:
  sim.c:149:11: warning: variable ‘payload’ set but not used
                         [-Wunused-but-set-variable]
    uint8_t *payload;

Change-Id: I3767b23bb1b28d3f4bb515d399bce160ba2eee09
---
M src/host/layer23/src/common/sim.c
1 file changed, 0 insertions(+), 2 deletions(-)

Approvals:
  Jenkins Builder: Verified
  Harald Welte: Looks good to me, approved



diff --git a/src/host/layer23/src/common/sim.c b/src/host/layer23/src/common/sim.c
index a63ae2a..f214e67 100644
--- a/src/host/layer23/src/common/sim.c
+++ b/src/host/layer23/src/common/sim.c
@@ -146,7 +146,6 @@
 	struct gsm_sim *sim = &ms->sim;
 	struct msgb *msg = sim->job_msg;
 	struct sim_hdr *sh;
-	uint8_t *payload;
 	uint16_t payload_len;
 	struct gsm_sim_handler *handler;
 
@@ -165,7 +164,6 @@
 		return;
 	}
 
-	payload = msg->data + sizeof(*sh);
 	payload_len = msg->len - sizeof(*sh);
 
 	/* remove data */

-- 
To view, visit https://gerrit.osmocom.org/12785
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I3767b23bb1b28d3f4bb515d399bce160ba2eee09
Gerrit-Change-Number: 12785
Gerrit-PatchSet: 1
Gerrit-Owner: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Vadim Yanitskiy <axilirator at gmail.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190203/9869f9c8/attachment.htm>


More information about the gerrit-log mailing list