This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Vadim Yanitskiy gerrit-no-reply at lists.osmocom.orgVadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/12779 ) Change subject: scheduler_trx: use stored block fn instead of calculating it. ...................................................................... Patch Set 1: Code-Review-2 (6 comments) https://gerrit.osmocom.org/#/c/12779/1/src/osmo-bts-trx/scheduler_trx.c File src/osmo-bts-trx/scheduler_trx.c: https://gerrit.osmocom.org/#/c/12779/1/src/osmo-bts-trx/scheduler_trx.c@949 PS1, Line 949: first_fn I am agree here, as a PDTCH block is interleaved over 4 consequent bursts. Similar to xCCH. https://gerrit.osmocom.org/#/c/12779/1/src/osmo-bts-trx/scheduler_trx.c@1073 PS1, Line 1073: first_fn Sorry, but this change makes the situation with TCH frame number calculation even worse. Both TCH/F (speech) and FACCH/F blocks are being interleaved over 8 bursts, so this is why we have 'fn - 7'. Neither the current, nor the suggested approach is correct. After this change we would have the frame number of 5/8 burst instead of 1/8, because we update *first_fn when bid == 0. Doing 'fn - 7' is (I think) also incorrect because there are SACCH and IDLE frames between the TCH/F frames. As I already pointed out, we need some functions for such calculations, which would rely on the multi-frame layout. https://gerrit.osmocom.org/#/c/12779/1/src/osmo-bts-trx/scheduler_trx.c@1126 PS1, Line 1126: first_fn same here :/ https://gerrit.osmocom.org/#/c/12779/1/src/osmo-bts-trx/scheduler_trx.c@1263 PS1, Line 1263: first_fn Here it's even more complicated, so this change would result in having frame number of 5/6 burst instead of 1/6 for FACCH/H. https://gerrit.osmocom.org/#/c/12779/1/src/osmo-bts-trx/scheduler_trx.c@1306 PS1, Line 1306: printf Left from debugging? ;) https://gerrit.osmocom.org/#/c/12779/1/src/osmo-bts-trx/scheduler_trx.c@1307 PS1, Line 1307: first_fn ... and here we would have frame number of 3/4 burst instead of 1/4. -- To view, visit https://gerrit.osmocom.org/12779 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia27254bbf6e36426f7890ece6154dcd395673f63 Gerrit-Change-Number: 12779 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier at sysmocom.de> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Vadim Yanitskiy <axilirator at gmail.com> Gerrit-Comment-Date: Fri, 01 Feb 2019 18:12:26 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: Yes -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190201/fa2a56ec/attachment.htm>