Change in osmo-bts[master]: l1sap: is_fille_frame(): verify len of data compared

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

laforge gerrit-no-reply at lists.osmocom.org
Tue Dec 31 17:02:35 UTC 2019


laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/16661 )

Change subject: l1sap: is_fille_frame(): verify len of data compared
......................................................................

l1sap: is_fille_frame(): verify len of data compared

Change-Id: Id3d1725ff36091ed5c57927caad09a8baea6f52e
---
M src/common/l1sap.c
1 file changed, 3 insertions(+), 0 deletions(-)

Approvals:
  Jenkins Builder: Verified
  fixeria: Looks good to me, but someone else must approve
  laforge: Looks good to me, approved



diff --git a/src/common/l1sap.c b/src/common/l1sap.c
index 213099d..b6e21fa 100644
--- a/src/common/l1sap.c
+++ b/src/common/l1sap.c
@@ -458,6 +458,9 @@
 
 static bool is_fill_frame(uint8_t chan_type, const uint8_t *data, unsigned int len)
 {
+	if (len != GSM_MACBLOCK_LEN)
+		return false;
+
 	switch (chan_type) {
 	case GSMTAP_CHANNEL_AGCH:
 		if (!memcmp(data, fill_frame, GSM_MACBLOCK_LEN))

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/16661
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: Id3d1725ff36091ed5c57927caad09a8baea6f52e
Gerrit-Change-Number: 16661
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <axilirator at gmail.com>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20191231/f9a2fb6b/attachment.htm>


More information about the gerrit-log mailing list