Change in osmo-bts[master]: osmo-bts-trx/vty: ensure backwards compatibility with older config files

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

pespin gerrit-no-reply at lists.osmocom.org
Thu Dec 19 12:11:40 UTC 2019


pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/16653 )

Change subject: osmo-bts-trx/vty: ensure backwards compatibility with older config files
......................................................................


Patch Set 1: Code-Review-1

(2 comments)

https://gerrit.osmocom.org/c/osmo-bts/+/16653/1/src/common/vty.c 
File src/common/vty.c:

https://gerrit.osmocom.org/c/osmo-bts/+/16653/1/src/common/vty.c@796 
PS1, Line 796: 		 * which has been ripped out recently. Configuration files may still contain
"recently" may be confusing when someone reads this after a while ;)


https://gerrit.osmocom.org/c/osmo-bts/+/16653/1/src/common/vty.c@802 
PS1, Line 802: 			return CMD_SUCCESS;
iiuc this return should be removed. Otherwise there's no sense in setting soft. But anyway, since it's set to "osmo" by default in case of osmo-bts-trx (because dsp doesn't exist anymore), it means we can simply return CMD_SUCCESS as in ignoring the CMD.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/16653
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I4facd21bca3d8cb80d21e83ea267bc013e474533
Gerrit-Change-Number: 16653
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <axilirator at gmail.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <axilirator at gmail.com>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Thu, 19 Dec 2019 12:11:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20191219/34e41931/attachment.htm>


More information about the gerrit-log mailing list