Change in osmo-ttcn3-hacks[master]: msc: Introduce test TC_lu_imsi_timeout_tmsi_realloc

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

neels gerrit-no-reply at lists.osmocom.org
Tue Dec 17 17:41:08 UTC 2019


neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16648 )

Change subject: msc: Introduce test TC_lu_imsi_timeout_tmsi_realloc
......................................................................


Patch Set 1: Code-Review+1

(2 comments)

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16648/1/msc/MSC_Tests.ttcn 
File msc/MSC_Tests.ttcn:

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16648/1/msc/MSC_Tests.ttcn@565 
PS1, Line 565: /* MSC sends a LU REJECT after X1 times out (5 seconds by default) */
(opening comment inside a still open comment)


https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16648/1/msc/MSC_Tests.ttcn@603 
PS1, Line 603: 	f_expect_clear();
The "Congestion" cause was just a wild guess, assuming that the last message failed to get processed in time.
We could write '?' as cause here to not make it appear like cast in stone in the specs.

It could be easier to tweak the f_perform_lu() function with optional parameters.
IIUC all you need is the same f_perform_lu(), only with a flag that skips sending the 'TMSI Reallocation Complete' and exits early (in f_accept_reject_lu()); then you can f_expect_lu_reject() here?

(OTOH, this is unlikely to get refactored / change ordering, so it's also fine like this)



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16648
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I603b2b2b1ae7edd6360ea38c6bbbfedc46e9fa5d
Gerrit-Change-Number: 16648
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de>
Gerrit-Comment-Date: Tue, 17 Dec 2019 17:41:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20191217/a0d621a0/attachment.htm>


More information about the gerrit-log mailing list