This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
laforge gerrit-no-reply at lists.osmocom.orglaforge has submitted this change. ( https://gerrit.osmocom.org/c/simtrace2/+/16637 ) Change subject: firmware: Reformat value_string to pass our validation scripts ...................................................................... firmware: Reformat value_string to pass our validation scripts This is a purely cosmetic change in terms of coding style, but it fixes an [invalid] detection for unterminated value_string arrays by our verify_value_string_arrays_are_terminated.py script: Change-Id: I2f2370a673074f6bf5380106b6254b4aa1e8a792 ERROR: file contains unterminated value_string 'struct value_string iso7816_3_card_state_names[]': './deps/simtrace2/firmware/libcommon/source/card_emu.c' ERROR: file contains unterminated value_string 'struct value_string tpdu_state_names[]': './deps/simtrace2/firmware/libcommon/source/card_emu.c' --- M firmware/libcommon/source/card_emu.c M firmware/libcommon/source/sniffer.c 2 files changed, 22 insertions(+), 88 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/firmware/libcommon/source/card_emu.c b/firmware/libcommon/source/card_emu.c index 7a541e5..cad24b8 100644 --- a/firmware/libcommon/source/card_emu.c +++ b/firmware/libcommon/source/card_emu.c @@ -58,42 +58,15 @@ }; const struct value_string iso7816_3_card_state_names[] = { - { - .value = ISO_S_WAIT_POWER, - .str = "WAIT_POWER", - }, - { - .value = ISO_S_WAIT_CLK, - .str = "WAIT_CLK", - }, - { - .value = ISO_S_WAIT_RST, - .str = "WAIT_RST", - }, - { - .value = ISO_S_WAIT_ATR, - .str = "WAIT_ATR", - }, - { - .value = ISO_S_IN_ATR, - .str = "IN_ATR", - }, - { - .value = ISO_S_IN_PTS, - .str = "IN_PTS", - }, - { - .value = ISO_S_WAIT_TPDU, - .str = "WAIT_TPDU", - }, - { - .value = ISO_S_IN_TPDU, - .str = "IN_TPDU", - }, - { - .value = 0, - .str = NULL, - }, + { ISO_S_WAIT_POWER, "WAIT_POWER" }, + { ISO_S_WAIT_CLK, "WAIT_CLK" }, + { ISO_S_WAIT_RST, "WAIT_RST" }, + { ISO_S_WAIT_ATR, "WAIT_ATR" }, + { ISO_S_IN_ATR, "IN_ATR" }, + { ISO_S_IN_PTS, "IN_PTS" }, + { ISO_S_WAIT_TPDU, "WAIT_TPDU" }, + { ISO_S_IN_TPDU, "IN_TPDU" }, + { 0, NULL } }; @@ -150,42 +123,15 @@ }; const struct value_string tpdu_state_names[] = { - { - .value = TPDU_S_WAIT_CLA, - .str = "WAIT_CLA", - }, - { - .value = TPDU_S_WAIT_INS, - .str = "WAIT_INS", - }, - { - .value = TPDU_S_WAIT_P1, - .str = "WAIT_P1", - }, - { - .value = TPDU_S_WAIT_P2, - .str = "WAIT_P2", - }, - { - .value = TPDU_S_WAIT_P3, - .str = "WAIT_P3", - }, - { - .value = TPDU_S_WAIT_PB, - .str = "WAIT_PB", - }, - { - .value = TPDU_S_WAIT_RX, - .str = "WAIT_RX", - }, - { - .value = TPDU_S_WAIT_TX, - .str = "WAIT_TX", - }, - { - .value = 0, - .str = NULL, - }, + { TPDU_S_WAIT_CLA, "WAIT_CLA" }, + { TPDU_S_WAIT_INS, "WAIT_INS" }, + { TPDU_S_WAIT_P1, "WAIT_P1" }, + { TPDU_S_WAIT_P2, "WAIT_P2" }, + { TPDU_S_WAIT_P3, "WAIT_P3" }, + { TPDU_S_WAIT_PB, "WAIT_PB" }, + { TPDU_S_WAIT_RX, "WAIT_RX" }, + { TPDU_S_WAIT_TX, "WAIT_TX" }, + { 0, NULL } }; /* TPDU field byte index */ diff --git a/firmware/libcommon/source/sniffer.c b/firmware/libcommon/source/sniffer.c index 82c4b3f..08770e2 100644 --- a/firmware/libcommon/source/sniffer.c +++ b/firmware/libcommon/source/sniffer.c @@ -303,22 +303,10 @@ } const struct value_string data_flags[] = { - { - .value = SNIFF_DATA_FLAG_ERROR_INCOMPLETE, - .str = "incomplete", - }, - { - .value = SNIFF_DATA_FLAG_ERROR_MALFORMED, - .str = "malformed", - }, - { - .value = SNIFF_DATA_FLAG_ERROR_CHECKSUM, - .str = "checksum error", - }, - { - .value = 0, - .str = NULL, - }, + { SNIFF_DATA_FLAG_ERROR_INCOMPLETE, "incomplete" }, + { SNIFF_DATA_FLAG_ERROR_MALFORMED, "malformed" }, + { SNIFF_DATA_FLAG_ERROR_CHECKSUM, "checksum error" }, + { 0, NULL } }; static void print_flags(const struct value_string* flag_meanings, uint32_t nb_flags, uint32_t flags) { -- To view, visit https://gerrit.osmocom.org/c/simtrace2/+/16637 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: simtrace2 Gerrit-Branch: master Gerrit-Change-Id: I2f2370a673074f6bf5380106b6254b4aa1e8a792 Gerrit-Change-Number: 16637 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge at osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge at osmocom.org> Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20191217/7ae28e7f/attachment.htm>