This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
laforge gerrit-no-reply at lists.osmocom.orglaforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/16619 ) Change subject: Introduce helper functions for safe fork+exec of processes ...................................................................... Patch Set 2: (4 comments) https://gerrit.osmocom.org/c/libosmocore/+/16619/2/src/exec.c File src/exec.c: https://gerrit.osmocom.org/c/libosmocore/+/16619/2/src/exec.c@64 PS2, Line 64: /*! generate a filtered version of the process environment containing only entries of whitelisted keys. > Worth mentioning that strings in our are shared from in, ie strings are not copied. Done https://gerrit.osmocom.org/c/libosmocore/+/16619/2/src/exec.c@67 PS2, Line 67: * \param[in] in input environment (NULL-terminated list of pointers like **environment) > worth mentioning where does this **environment come from. Done https://gerrit.osmocom.org/c/libosmocore/+/16619/2/src/exec.c@169 PS2, Line 169: extern char **environ; > unistd.h: […] I can see that in my unistd.h, too - but somehow it simply doesn't work. https://gerrit.osmocom.org/c/libosmocore/+/16619/2/src/exec.c@172 PS2, Line 172: int osmo_system_nowait(const char *command, char **addl_env) > addl_env? Please document the params. Done -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/16619 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ib24ac8a083db32e55402ce496a5eabd8749cc888 Gerrit-Change-Number: 16619 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge at osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge at osmocom.org> Gerrit-CC: pespin <pespin at sysmocom.de> Gerrit-Comment-Date: Tue, 17 Dec 2019 11:38:06 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin at sysmocom.de> Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20191217/73a4b28d/attachment.htm>