This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
laforge gerrit-no-reply at lists.osmocom.orglaforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/16619 ) Change subject: Introduce helper functions for safe fork+exec of processes ...................................................................... Patch Set 2: (2 comments) https://gerrit.osmocom.org/c/libosmocore/+/16619/2/src/exec.c File src/exec.c: https://gerrit.osmocom.org/c/libosmocore/+/16619/2/src/exec.c@116 PS2, Line 116: int osmo_environment_append(char **out, size_t out_len, char **in) > Not sure if appending an already existing key to the list makes it really overwrite it. […] I'll simply document that constraint to avoid spending more time on this right now. https://gerrit.osmocom.org/c/libosmocore/+/16619/2/src/exec.c@124 PS2, Line 124: for (out_used = 0; out[out_used]; out_used++) {} > for (out_used = 0; out[out_used]; out_used++); what's wrong with the {} ? -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/16619 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ib24ac8a083db32e55402ce496a5eabd8749cc888 Gerrit-Change-Number: 16619 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge at osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge at osmocom.org> Gerrit-CC: pespin <pespin at sysmocom.de> Gerrit-Comment-Date: Tue, 17 Dec 2019 11:27:35 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin at sysmocom.de> Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20191217/61ec4be2/attachment.htm>