Change in simtrace2[master]: card_emu: Remove extraneous code

[laforge]

laforge has submitted this change. ( https://gerrit.osmocom.org/c/simtrace2/+/16603 )

Change subject: card_emu: Remove extraneous code
......................................................................

card_emu: Remove extraneous code

card_set_state(ch, ISO_S_WAIT_ATR) internally calls tc_etu_enable(),
so there's no need for the caller to do the same, too.

Change-Id: I2a2b4d64c40264623313a867957ffcefe57748f9
---
M firmware/libcommon/source/card_emu.c
1 file changed, 1 insertion(+), 3 deletions(-)

Approvals:
  Jenkins Builder: Verified
  laforge: Looks good to me, approved



diff --git a/firmware/libcommon/source/card_emu.c b/firmware/libcommon/source/card_emu.c
index 4c29d41..5488fad 100644
--- a/firmware/libcommon/source/card_emu.c
+++ b/firmware/libcommon/source/card_emu.c
@@ -453,7 +453,7 @@
 		 * since the initial ETU is Fd=372/Dd=1 clock cycles long, we have to wait 2-107 ETU.
 		 */
 		tc_etu_set_wtime(ch->tc_chan, 2);
-		/* ensure the TC_ETU timer is enabled */
+		/* enable the TC/ETU counter once reset has been released */
 		tc_etu_enable(ch->tc_chan);
 		break;
 	case ISO_S_IN_ATR:
@@ -1129,8 +1129,6 @@
 		/* check end activation state (even if the reader does
 		 * not respect the activation sequence) */
 		if (ch->vcc_active && ch->clocked && !ch->in_reset) {
-			/* enable the TC/ETU counter once reset has been released */
-			tc_etu_enable(ch->tc_chan);
 			/* prepare to send the ATR */
 			card_set_state(ch, ISO_S_WAIT_ATR);
 		}

-- 
To view, visit https://gerrit.osmocom.org/c/simtrace2/+/16603
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: simtrace2
Gerrit-Branch: master
Gerrit-Change-Id: I2a2b4d64c40264623313a867957ffcefe57748f9
Gerrit-Change-Number: 16603
Gerrit-PatchSet: 5
Gerrit-Owner: laforge <laforge at osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20191217/169ff60d/attachment.htm>