This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
neels gerrit-no-reply at lists.osmocom.orgneels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hlr/+/16205 ) Change subject: 1/2: refactor: add and use lu_fsm, osmo_gsup_req, osmo_ipa_name ...................................................................... Patch Set 22: (3 comments) This actually changes coding of the Routing Error message: So far a Routing Error sent back Source Name and Destination Name unchanged. In a setup with possibly a GSUP proxy between request and response, that is very cumbersome. It makes much more sense to put the requesting source in Destination Name, so that the error is implicitly routed back to the entity that requested the unreachable peer. Related: "add version IE?" https://osmocom.org/issues/4333 Places that introduce the "swap" of Destination and Source are... https://gerrit.osmocom.org/c/osmo-hlr/+/16205/22/src/gsup_server.c File src/gsup_server.c: https://gerrit.osmocom.org/c/osmo-hlr/+/16205/22/src/gsup_server.c@108 PS22, Line 108: osmo_gsup_req_respond_msgt(req, OSMO_GSUP_MSGT_ROUTING_ERROR, true); here https://gerrit.osmocom.org/c/osmo-hlr/+/16205/22/src/gsupclient/gsup_req.c File src/gsupclient/gsup_req.c: https://gerrit.osmocom.org/c/osmo-hlr/+/16205/22/src/gsupclient/gsup_req.c@85 PS22, Line 85: osmo_gsup_req_respond_msgt(req, OSMO_GSUP_MSGT_ROUTING_ERROR, true); here https://gerrit.osmocom.org/c/osmo-hlr/+/16205/22/src/hlr.c File src/hlr.c: https://gerrit.osmocom.org/c/osmo-hlr/+/16205/22/src/hlr.c@474 PS22, Line 474: .source_name_len = gsup->destination_name_len, here -- To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/16205 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hlr Gerrit-Branch: master Gerrit-Change-Id: I3a8dff3d4a1cbe10d6ab08257a0138d6b2a082d9 Gerrit-Change-Number: 16205 Gerrit-PatchSet: 22 Gerrit-Owner: neels <nhofmeyr at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge at osmocom.org> Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de> Gerrit-Reviewer: osmith <osmith at sysmocom.de> Gerrit-Comment-Date: Mon, 16 Dec 2019 14:06:57 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20191216/3e2660e1/attachment.htm>