This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
laforge gerrit-no-reply at lists.osmocom.orglaforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/simtrace2/+/16605 ) Change subject: card_emu: Remove extraneous initialization of ch->pts.state ...................................................................... card_emu: Remove extraneous initialization of ch->pts.state ch->pts.state is initialized every time we enter ISO_S_WAIT_TPDU state, so there's no need to reset it at other locations. KISS. Change-Id: I5ff8b2671c3c893cc5f6542d48b65487ae8c5be1 --- M firmware/libcommon/source/card_emu.c 1 file changed, 0 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/simtrace2 refs/changes/05/16605/1 diff --git a/firmware/libcommon/source/card_emu.c b/firmware/libcommon/source/card_emu.c index ac28805..f9c3673 100644 --- a/firmware/libcommon/source/card_emu.c +++ b/firmware/libcommon/source/card_emu.c @@ -240,8 +240,6 @@ tc_etu_disable(ch->tc_chan); - ch->tpdu.state = TPDU_S_WAIT_CLA; - /* release any buffers we may still own */ if (ch->uart_tx_msg) { usb_buf_free(ch->uart_tx_msg); -- To view, visit https://gerrit.osmocom.org/c/simtrace2/+/16605 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: simtrace2 Gerrit-Branch: master Gerrit-Change-Id: I5ff8b2671c3c893cc5f6542d48b65487ae8c5be1 Gerrit-Change-Number: 16605 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge at osmocom.org> Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20191215/8ebf9da6/attachment.htm>