This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
neels gerrit-no-reply at lists.osmocom.orgneels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/16218 ) Change subject: sms db: when storing an SMS, retrieve the ID ...................................................................... Patch Set 2: (1 comment) https://gerrit.osmocom.org/c/osmo-msc/+/16218/1/src/libmsc/db.c File src/libmsc/db.c: https://gerrit.osmocom.org/c/osmo-msc/+/16218/1/src/libmsc/db.c@773 PS1, Line 773: sms->id = dbi_conn_sequence_last(conn, "id"); > So we had an id which was always 0 until now? yes, but AFAICT no code path used it; we would instead always retrieve from the db later. Still it seems a sane thing to do in principle. -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/16218 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I5fa55307a6abb8bbfe56619235d7b79fbbda6caf Gerrit-Change-Number: 16218 Gerrit-PatchSet: 2 Gerrit-Owner: neels <nhofmeyr at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge at osmocom.org> Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de> Gerrit-CC: pespin <pespin at sysmocom.de> Gerrit-Comment-Date: Thu, 12 Dec 2019 15:46:25 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin at sysmocom.de> Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20191212/740954b4/attachment.htm>