Change in osmo-pcu[master]: Support Gb PAGING-CS

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

fixeria gerrit-no-reply at lists.osmocom.org
Wed Dec 11 01:40:28 UTC 2019


fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/16537 )

Change subject: Support Gb PAGING-CS
......................................................................


Patch Set 1: Code-Review+1

(2 comments)

https://gerrit.osmocom.org/c/osmo-pcu/+/16537/1/src/gprs_bssgp_pcu.cpp 
File src/gprs_bssgp_pcu.cpp:

https://gerrit.osmocom.org/c/osmo-pcu/+/16537/1/src/gprs_bssgp_pcu.cpp@178 
PS1, Line 178: 9
Where does this 9 come from BTW? Is it (GSM23003_IMSI_MAX_DIGITS + 1) / 2 + 1?

  * (GSM23003_IMSI_MAX_DIGITS + 1) == (15 + 1) -- 15 digits + 4 padding bits,
  * (GSM23003_IMSI_MAX_DIGITS + 1) / 2 -- amount of bytes to store the V part,
  * ... + 1 -- for the L part.

Maybe we need a new macro in osmocom/gsm/protocol/gsm_23_003.h?


https://gerrit.osmocom.org/c/osmo-pcu/+/16537/1/src/gprs_bssgp_pcu.cpp@196 
PS1, Line 196: No IMSI
"Neither TMSI IE nor IMSI IE is present"



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/16537
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: I9501e02e1d7f6944497e724dbccb9a19c3f5221f
Gerrit-Change-Number: 16537
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <axilirator at gmail.com>
Gerrit-Comment-Date: Wed, 11 Dec 2019 01:40:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20191211/1c0d1c3d/attachment.htm>


More information about the gerrit-log mailing list