Change in osmo-pcu[master]: Allow Gb PAGING-PS without P-TMSI

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

fixeria gerrit-no-reply at lists.osmocom.org
Wed Dec 11 01:26:36 UTC 2019


fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/16536 )

Change subject: Allow Gb PAGING-PS without P-TMSI
......................................................................


Patch Set 1:

(2 comments)

https://gerrit.osmocom.org/c/osmo-pcu/+/16536/1/src/gprs_bssgp_pcu.cpp 
File src/gprs_bssgp_pcu.cpp:

https://gerrit.osmocom.org/c/osmo-pcu/+/16536/1/src/gprs_bssgp_pcu.cpp@201 
PS1, Line 201: memcpy
I believe this transitional memcpy() call can be eliminated. You could still pass both TLVP_VAL(tp, BSSGP_IE_xMSI) and TLVP_LEN(tp, BSSGP_IE_xMSI) directly to gprs_rlcmac_paging_request().


https://gerrit.osmocom.org/c/osmo-pcu/+/16536/1/src/gprs_rlcmac.cpp 
File src/gprs_rlcmac.cpp:

https://gerrit.osmocom.org/c/osmo-pcu/+/16536/1/src/gprs_rlcmac.cpp@34 
PS1, Line 34: osmo_hexdump
Can we use osmo_mi_name() here?



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/16536
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: I4dbf8db04e81f98352a42ce34a5d91326be9bfd1
Gerrit-Change-Number: 16536
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-CC: fixeria <axilirator at gmail.com>
Gerrit-Comment-Date: Wed, 11 Dec 2019 01:26:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20191211/fbed56b1/attachment.htm>


More information about the gerrit-log mailing list