This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
laforge gerrit-no-reply at lists.osmocom.orglaforge has submitted this change. ( https://gerrit.osmocom.org/c/simtrace2/+/16514 ) Change subject: qmod DFU: Don't overwrite memory beyond end of usb_strings[] ...................................................................... qmod DFU: Don't overwrite memory beyond end of usb_strings[] The code in board_main_top() for QMOD blindly re-assigned some members of the usb_strings[] array, writing to index 7 and 8. However, that array only has those entries in the main firmware, while in DFU that array has only 6 entries. Depending on whatever the linker has decided to put in the next memory location after that array, we would overwrite that very early during boot-up. Change-Id: I59e4e1a54e819808d5a8259a6d14f4b970a90020 Related: OS#4302 --- M firmware/libboard/qmod/source/board_qmod.c 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/firmware/libboard/qmod/source/board_qmod.c b/firmware/libboard/qmod/source/board_qmod.c index 0565c92..0b03180 100644 --- a/firmware/libboard/qmod/source/board_qmod.c +++ b/firmware/libboard/qmod/source/board_qmod.c @@ -332,11 +332,13 @@ TRACE_INFO("Detected Quad-Modem ST12\n\r"); } else { TRACE_INFO("Detected Quad-Modem ST34\n\r"); +#ifndef APPLICATION_dfu /* make sure we use the second set of USB Strings * calling the interfaces "Modem 3" and "Modem 4" rather * than 1+2 */ usb_strings[7] = usb_strings[9]; usb_strings[8] = usb_strings[10]; +#endif } /* Obtain the circuit board version (currently just prints voltage */ -- To view, visit https://gerrit.osmocom.org/c/simtrace2/+/16514 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: simtrace2 Gerrit-Branch: master Gerrit-Change-Id: I59e4e1a54e819808d5a8259a6d14f4b970a90020 Gerrit-Change-Number: 16514 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge at osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge at osmocom.org> Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20191206/2e66bb3e/attachment.htm>