Change in osmo-ttcn3-hacks[master]: pcu: send UL CONTROL ACK triggered by DL ACK/NACK

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

pespin gerrit-no-reply at lists.osmocom.org
Thu Dec 5 18:18:45 UTC 2019


pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16501 )

Change subject: pcu: send UL CONTROL ACK triggered by DL ACK/NACK
......................................................................


Patch Set 3:

> Patch Set 3:
> 
> > Patch Set 3:
> > 
> > > Patch Set 3: Code-Review-1
> > > 
> > > (1 comment)
> > > 
> > > Sorry, I don't like this approach. It basically makes 1/10 use cases look shorter, while the rest 9/10 ones have to use a dummy variable.
> > 
> > That's 9/10 of the specific simple scenarios we have NOW. Believe this is useful in more "usual MS" scenarios like the ones I submit after this one.
> 
> Ok, but still, you can just access that field directly since it's already exposed as a part of the record.

Yes for that part but not the req_fn from pcu_msg. And in most cases the interesting information is the calculated poll_fn so it can simply be passed over in forthcoming tests like I'm already doing.

I'm not saying it should stay like this forever, but for now it proves useful for next tests. If at some point we add more complexity we can also move this around as we think fits better.


-- 
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16501
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ib409394257427cfc62da08fe06ce6c001dcf608a
Gerrit-Change-Number: 16501
Gerrit-PatchSet: 3
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <axilirator at gmail.com>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Thu, 05 Dec 2019 18:18:45 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20191205/642ace00/attachment.htm>


More information about the gerrit-log mailing list