Change in libosmocore[master]: utils: exit(2) on unsupported positional arguments on command line

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

laforge gerrit-no-reply at lists.osmocom.org
Wed Dec 4 11:20:47 UTC 2019


laforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/16445 )

Change subject: utils: exit(2) on unsupported positional arguments on command line
......................................................................

utils: exit(2) on unsupported positional arguments on command line

Change-Id: Icc76cae2225ec4e664b950176dd861fa15712f59
---
M utils/osmo-arfcn.c
M utils/osmo-auc-gen.c
2 files changed, 10 insertions(+), 0 deletions(-)

Approvals:
  Jenkins Builder: Verified
  pespin: Looks good to me, approved



diff --git a/utils/osmo-arfcn.c b/utils/osmo-arfcn.c
index 5087842..5f138f8 100644
--- a/utils/osmo-arfcn.c
+++ b/utils/osmo-arfcn.c
@@ -128,6 +128,11 @@
 		}
 	}
 
+	if (argc > optind) {
+		fprintf(stderr, "Unsupported positional arguments in command line\n");
+		exit(2);
+	}
+
 	switch (mode) {
 	case MODE_NONE:
 		help(argv[0]);
diff --git a/utils/osmo-auc-gen.c b/utils/osmo-auc-gen.c
index ec9bad8..65cfa31 100644
--- a/utils/osmo-auc-gen.c
+++ b/utils/osmo-auc-gen.c
@@ -247,6 +247,11 @@
 		}
 	}
 
+	if (argc > optind) {
+		fprintf(stderr, "Unsupported positional arguments in command line\n");
+		exit(2);
+	}
+
 	if (!rand_is_set) {
 		rc = osmo_get_rand_id(_rand, 16);
 		if (rc < 0) {

-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/16445
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Icc76cae2225ec4e664b950176dd861fa15712f59
Gerrit-Change-Number: 16445
Gerrit-PatchSet: 1
Gerrit-Owner: laforge <laforge at osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20191204/9af8d6af/attachment.htm>


More information about the gerrit-log mailing list