Change in osmo-trx[master]: trx: exit() on unsupported positional arguments on command line

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

laforge gerrit-no-reply at lists.osmocom.org
Tue Dec 3 20:41:45 UTC 2019


laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-trx/+/16446 )


Change subject: trx: exit() on unsupported positional arguments on command line
......................................................................

trx: exit() on unsupported positional arguments on command line

Change-Id: Ifeea65a359e9ca307efb2c721fd0fb6f0959e976
---
M Transceiver52M/osmo-trx.cpp
1 file changed, 5 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-trx refs/changes/46/16446/1

diff --git a/Transceiver52M/osmo-trx.cpp b/Transceiver52M/osmo-trx.cpp
index 2346488..16047a9 100644
--- a/Transceiver52M/osmo-trx.cpp
+++ b/Transceiver52M/osmo-trx.cpp
@@ -381,6 +381,11 @@
 		}
 	}
 
+	if (argc > optind) {
+		LOG(ERROR) << "Unsupported positional arguments on command line";
+		goto bad_config;
+	}
+
 	/* Cmd line option specific validation & setup */
 
 	if (trx->cfg.num_chans > TRX_CHAN_MAX) {

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/16446
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-Change-Id: Ifeea65a359e9ca307efb2c721fd0fb6f0959e976
Gerrit-Change-Number: 16446
Gerrit-PatchSet: 1
Gerrit-Owner: laforge <laforge at osmocom.org>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20191203/580e68e7/attachment.htm>


More information about the gerrit-log mailing list