Change in osmo-ttcn3-hacks[master]: hlr: Don't attempt to find AUTN in 2G-only tuple

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

laforge gerrit-no-reply at lists.osmocom.org
Tue Dec 3 19:12:15 UTC 2019


laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16442 )

Change subject: hlr: Don't attempt to find AUTN in 2G-only tuple
......................................................................

hlr: Don't attempt to find AUTN in 2G-only tuple

In Change-Id I40c6cf7e28ad9331e6c27fe7acafa3f9e277eedf we introduced
a patch that verifies the AMF separation bit for 3G/3G vs 4G
authentication.  However, the test ignored the fact that AUTN cannot
be present in pure 2G tuples.

This makes TC_gsup_sai pass again.

Change-Id: I9b61e62a58b583461dd5e67dd12119be282cae21
---
M hlr/HLR_Tests.ttcn
1 file changed, 3 insertions(+), 1 deletion(-)

Approvals:
  Jenkins Builder: Verified
  laforge: Looks good to me, approved



diff --git a/hlr/HLR_Tests.ttcn b/hlr/HLR_Tests.ttcn
index 8a96d7f..50109a6 100644
--- a/hlr/HLR_Tests.ttcn
+++ b/hlr/HLR_Tests.ttcn
@@ -711,7 +711,9 @@
 private function f_TC_gsup_sai() runs on HLR_ConnHdlr {
 	var GSUP_PDU res;
 	res := f_perform_SAI(g_pars.sub.imsi);
-	f_ensure_amf_separation_bit(res, '0'B);
+	if (ispresent(g_pars.sub.aud3g)) {
+		f_ensure_amf_separation_bit(res, '0'B);
+	}
 	/* TODO: match if tuple[s] matches expectation */
 	setverdict(pass);
 }

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16442
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I9b61e62a58b583461dd5e67dd12119be282cae21
Gerrit-Change-Number: 16442
Gerrit-PatchSet: 1
Gerrit-Owner: laforge <laforge at osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20191203/733969bd/attachment.htm>


More information about the gerrit-log mailing list