Change in osmo-mgw[master]: mgcp_client: Check for osmo_fsm_register() error return value

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

laforge gerrit-no-reply at lists.osmocom.org
Sun Dec 1 20:01:27 UTC 2019


laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/16361 )

Change subject: mgcp_client: Check for osmo_fsm_register() error return value
......................................................................

mgcp_client: Check for osmo_fsm_register() error return value

Change-Id: Ie5e7fa419117349d098b0158ed840341094f3c16
---
M src/libosmo-mgcp-client/mgcp_client_fsm.c
1 file changed, 2 insertions(+), 1 deletion(-)

Approvals:
  Jenkins Builder: Verified
  fixeria: Looks good to me, but someone else must approve
  laforge: Looks good to me, approved



diff --git a/src/libosmo-mgcp-client/mgcp_client_fsm.c b/src/libosmo-mgcp-client/mgcp_client_fsm.c
index 800ae1b..e910586 100644
--- a/src/libosmo-mgcp-client/mgcp_client_fsm.c
+++ b/src/libosmo-mgcp-client/mgcp_client_fsm.c
@@ -620,7 +620,8 @@
 
 	/* Register the fsm description (if not already done) */
 	if (fsm_registered == false) {
-		osmo_fsm_register(&fsm_mgcp_client);
+		if (osmo_fsm_register(&fsm_mgcp_client) < 0)
+			return NULL;
 		fsm_registered = true;
 	}
 

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/16361
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Gerrit-Change-Id: Ie5e7fa419117349d098b0158ed840341094f3c16
Gerrit-Change-Number: 16361
Gerrit-PatchSet: 2
Gerrit-Owner: laforge <laforge at osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <axilirator at gmail.com>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20191201/9f41b1b7/attachment.htm>


More information about the gerrit-log mailing list