Change in osmo-msc[master]: Check for osmo_fsm_register() error return value

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

laforge gerrit-no-reply at lists.osmocom.org
Sun Dec 1 14:43:31 UTC 2019


laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/16382 )

Change subject: Check for osmo_fsm_register() error return value
......................................................................

Check for osmo_fsm_register() error return value

Change-Id: I4cce3d6798fe3184a3085d114b749b4645620978
---
M src/libmsc/mncc_call.c
M src/libmsc/msc_ho.c
2 files changed, 2 insertions(+), 2 deletions(-)

Approvals:
  laforge: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/src/libmsc/mncc_call.c b/src/libmsc/mncc_call.c
index e5fc820..0deb903 100644
--- a/src/libmsc/mncc_call.c
+++ b/src/libmsc/mncc_call.c
@@ -60,7 +60,7 @@
 
 void mncc_call_fsm_init(struct gsm_network *net)
 {
-	osmo_fsm_register(&mncc_call_fsm);
+	OSMO_ASSERT(osmo_fsm_register(&mncc_call_fsm) == 0);
 	gsmnet = net;
 }
 
diff --git a/src/libmsc/msc_ho.c b/src/libmsc/msc_ho.c
index 99f37b6..ac7602f 100644
--- a/src/libmsc/msc_ho.c
+++ b/src/libmsc/msc_ho.c
@@ -62,7 +62,7 @@
 
 static __attribute__((constructor)) void msc_ho_fsm_init()
 {
-	osmo_fsm_register(&msc_ho_fsm);
+	OSMO_ASSERT(osmo_fsm_register(&msc_ho_fsm) == 0);
 }
 
 void msc_ho_down_required_reject(struct msc_a *msc_a, enum gsm0808_cause cause)

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/16382
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: I4cce3d6798fe3184a3085d114b749b4645620978
Gerrit-Change-Number: 16382
Gerrit-PatchSet: 1
Gerrit-Owner: laforge <laforge at osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20191201/7e24106b/attachment.htm>


More information about the gerrit-log mailing list