This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
laforge gerrit-no-reply at lists.osmocom.orglaforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/16367 ) Change subject: Check for osmo_fsm_register() error return value ...................................................................... Check for osmo_fsm_register() error return value Change-Id: Idbc1557739b2a253b73914e6f1f18a6d169d882e --- M tests/fsm/fsm_dealloc_test.c M tests/fsm/fsm_test.c M tests/tdef/tdef_test.c M tests/use_count/use_count_test.c 4 files changed, 4 insertions(+), 4 deletions(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, approved laforge: Looks good to me, approved diff --git a/tests/fsm/fsm_dealloc_test.c b/tests/fsm/fsm_dealloc_test.c index 9a6974d..48f80e5 100644 --- a/tests/fsm/fsm_dealloc_test.c +++ b/tests/fsm/fsm_dealloc_test.c @@ -452,7 +452,7 @@ log_set_category_filter(osmo_stderr_target, DLGLOBAL, 1, LOGL_DEBUG); - osmo_fsm_register(&test_fsm); + OSMO_ASSERT(osmo_fsm_register(&test_fsm) == 0); test_osmo_fsm_term_safely(); test_osmo_fsm_set_dealloc_ctx(); diff --git a/tests/fsm/fsm_test.c b/tests/fsm/fsm_test.c index f8ebdc7..911aad8 100644 --- a/tests/fsm/fsm_test.c +++ b/tests/fsm/fsm_test.c @@ -417,7 +417,7 @@ g_ctx = NULL; OSMO_ASSERT(osmo_fsm_find_by_name(fsm.name) == NULL); - osmo_fsm_register(&fsm); + OSMO_ASSERT(osmo_fsm_register(&fsm) == 0); OSMO_ASSERT(osmo_fsm_find_by_name(fsm.name) == &fsm); OSMO_ASSERT(osmo_fsm_inst_find_by_name(&fsm, "my_id") == NULL); diff --git a/tests/tdef/tdef_test.c b/tests/tdef/tdef_test.c index 276330a..9c0808e 100644 --- a/tests/tdef/tdef_test.c +++ b/tests/tdef/tdef_test.c @@ -475,7 +475,7 @@ log_set_print_category(osmo_stderr_target, 1); log_set_use_color(osmo_stderr_target, 0); - osmo_fsm_register(&test_tdef_fsm); + OSMO_ASSERT(osmo_fsm_register(&test_tdef_fsm) == 0); test_tdef_get(argc > 1); test_tdef_get_nonexisting(); diff --git a/tests/use_count/use_count_test.c b/tests/use_count/use_count_test.c index 0b081c9..95af308 100644 --- a/tests/use_count/use_count_test.c +++ b/tests/use_count/use_count_test.c @@ -331,7 +331,7 @@ log_set_print_level(osmo_stderr_target, 1); log_set_use_color(osmo_stderr_target, 0); - osmo_fsm_register(&foo_fsm); + OSMO_ASSERT(osmo_fsm_register(&foo_fsm) == 0); test_use_count_fsm(); -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/16367 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Idbc1557739b2a253b73914e6f1f18a6d169d882e Gerrit-Change-Number: 16367 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge at osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <axilirator at gmail.com> Gerrit-Reviewer: laforge <laforge at osmocom.org> Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20191201/8e714fa0/attachment.htm>