Change in ...osmo-ttcn3-hacks[master]: HLR: Add test for generating EPS (LTE) tuples with separation bit == 1

pespin gerrit-no-reply at lists.osmocom.org
Fri Aug 30 20:46:18 UTC 2019


pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15366 )

Change subject: HLR: Add test for generating EPS (LTE) tuples with separation bit == 1
......................................................................


Patch Set 1:

(2 comments)

https://gerrit.osmocom.org/#/c/15366/1/hlr/HLR_Tests.ttcn 
File hlr/HLR_Tests.ttcn:

https://gerrit.osmocom.org/#/c/15366/1/hlr/HLR_Tests.ttcn@408 
PS1, Line 408: 		GSUP.send(ts_GSUP_SAI_REQ_EPS(imsi));
What about adding is_eps as a parameter to ts_GSUP_SAI_REQ_EPS()?


https://gerrit.osmocom.org/#/c/15366/1/hlr/HLR_Tests.ttcn@742 
PS1, Line 742: 	/* TODO: match if tuple[s] matches expectation */
I think you can drop this TODO since matching is done inside f_ensure_*()



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15366
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I40c6cf7e28ad9331e6c27fe7acafa3f9e277eedf
Gerrit-Change-Number: 15366
Gerrit-PatchSet: 1
Gerrit-Owner: laforge <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Fri, 30 Aug 2019 20:46:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190830/83810023/attachment.html>


More information about the gerrit-log mailing list