Change in ...osmo-ggsn[master]: gtp_error_ind_conf(): fix: guard against an unknown GTP version

fixeria gerrit-no-reply at lists.osmocom.org
Fri Aug 30 19:26:09 UTC 2019


fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/15368


Change subject: gtp_error_ind_conf(): fix: guard against an unknown GTP version
......................................................................

gtp_error_ind_conf(): fix: guard against an unknown GTP version

This change fixes the following compiler warnings (found by Clang):

  gtp.c:2747:13: warning: variable 'pdp' is used uninitialized
			  whenever 'if' condition is false
			  [-Wsometimes-uninitialized]
		 } else if (version == 1) {

  gtp.c:2781:14: note: uninitialized use occurs here
  		 OSMO_ASSERT(pdp);
			     ^^^

Shall not happen in general, but let's make Clang happy.

Change-Id: Id471b22afd4c45435589a4edda0a804e66be3a7a
---
M gtp/gtp.c
1 file changed, 3 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-ggsn refs/changes/68/15368/1

diff --git a/gtp/gtp.c b/gtp/gtp.c
index b18f76f..8b2373e 100644
--- a/gtp/gtp.c
+++ b/gtp/gtp.c
@@ -2768,6 +2768,9 @@
 			GTP_LOGPKG(LOGL_ERROR, peer, pack, len, "Unknown PDP context\n");
 			return EOF;
 		}
+	} else {
+		LOGP(DLGTP, LOGL_ERROR, "Unknown version: %d\n", version);
+		return EOF;
 	}
 
 	GTP_LOGPKG(LOGL_ERROR, peer, pack, len,

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-ggsn/+/15368
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ggsn
Gerrit-Branch: master
Gerrit-Change-Id: Id471b22afd4c45435589a4edda0a804e66be3a7a
Gerrit-Change-Number: 15368
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <axilirator at gmail.com>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190830/a46724a4/attachment.html>


More information about the gerrit-log mailing list