Change in ...osmo-sgsn[master]: Move out gbproxy to its own subdir

pespin gerrit-no-reply at lists.osmocom.org
Fri Aug 30 19:07:04 UTC 2019


pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/15361


Change subject: Move out gbproxy to its own subdir
......................................................................

Move out gbproxy to its own subdir

Change-Id: I2cc98d3a276d953609bbbbaa9782a0112687791e
---
M configure.ac
M debian/copyright
M osmoappdesc.py
M src/Makefile.am
A src/gbproxy/Makefile.am
R src/gbproxy/gb_proxy.c
R src/gbproxy/gb_proxy_ctrl.c
R src/gbproxy/gb_proxy_main.c
R src/gbproxy/gb_proxy_patch.c
R src/gbproxy/gb_proxy_peer.c
R src/gbproxy/gb_proxy_tlli.c
R src/gbproxy/gb_proxy_vty.c
M src/gprs/Makefile.am
M tests/gbproxy/Makefile.am
M tests/vty_test_runner.py
15 files changed, 62 insertions(+), 30 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-sgsn refs/changes/61/15361/1

diff --git a/configure.ac b/configure.ac
index 02dcf05..1c3f03b 100644
--- a/configure.ac
+++ b/configure.ac
@@ -247,6 +247,7 @@
     include/osmocom/sgsn/Makefile
     src/Makefile
     src/gprs/Makefile
+    src/gbproxy/Makefile
     tests/Makefile
     tests/atlocal
     tests/gprs/Makefile
diff --git a/debian/copyright b/debian/copyright
index b9bc8e0..695d768 100644
--- a/debian/copyright
+++ b/debian/copyright
@@ -86,12 +86,12 @@
            src/gprs/gprs_gb_parse.c
            src/gprs/gprs_utils.c
            src/gprs/sgsn_ares.c
-           src/gprs/gb_proxy.c
-           src/gprs/gb_proxy_main.c
-           src/gprs/gb_proxy_patch.c
-           src/gprs/gb_proxy_peer.c
-           src/gprs/gb_proxy_tlli.c
-           src/gprs/gb_proxy_vty.c
+           src/gbproxy/gb_proxy.c
+           src/gbproxy/gb_proxy_main.c
+           src/gbproxy/gb_proxy_patch.c
+           src/gbproxy/gb_proxy_peer.c
+           src/gbproxy/gb_proxy_tlli.c
+           src/gbproxy/gb_proxy_vty.c
            src/gprs/gprs_gmm.c
            src/gprs/gprs_llc.c
            src/gprs/gprs_llc_vty.c
diff --git a/osmoappdesc.py b/osmoappdesc.py
index f610e77..1c47aee 100644
--- a/osmoappdesc.py
+++ b/osmoappdesc.py
@@ -23,7 +23,7 @@
 }
 
 
-apps = [(4246, "src/gprs/osmo-gbproxy", "OsmoGbProxy", "gbproxy"),
+apps = [(4246, "src/gbproxy/osmo-gbproxy", "OsmoGbProxy", "gbproxy"),
         (4245, "src/gprs/osmo-sgsn", "OsmoSGSN", "sgsn"),
         (4253, "src/gprs/osmo-gtphub", "OsmoGTPhub", "gtphub")
         ]
diff --git a/src/Makefile.am b/src/Makefile.am
index d2dcb9f..024938d 100644
--- a/src/Makefile.am
+++ b/src/Makefile.am
@@ -1,3 +1,4 @@
 SUBDIRS = \
 	gprs \
+	gbproxy \
 	$(NULL)
diff --git a/src/gbproxy/Makefile.am b/src/gbproxy/Makefile.am
new file mode 100644
index 0000000..6876f68
--- /dev/null
+++ b/src/gbproxy/Makefile.am
@@ -0,0 +1,46 @@
+AM_CPPFLAGS = \
+	$(all_includes) \
+	-I$(top_srcdir)/include \
+	-I$(top_builddir) \
+	$(NULL)
+
+AM_CFLAGS = \
+	-Wall \
+	-fno-strict-aliasing \
+	$(LIBOSMOCORE_CFLAGS) \
+	$(LIBOSMOGSM_CFLAGS) \
+	$(LIBOSMOVTY_CFLAGS) \
+	$(LIBOSMOCTRL_CFLAGS) \
+	$(LIBOSMOABIS_CFLAGS) \
+	$(LIBOSMOGB_CFLAGS) \
+	$(LIBOSMOGSUPCLIENT_CFLAGS) \
+	$(COVERAGE_CFLAGS) \
+	$(LIBGTP_CFLAGS) \
+	$(NULL)
+
+bin_PROGRAMS = \
+	osmo-gbproxy \
+	$(NULL)
+
+osmo_gbproxy_SOURCES = \
+	gb_proxy.c \
+	gb_proxy_main.c \
+	gb_proxy_vty.c \
+	gb_proxy_ctrl.c \
+	gb_proxy_patch.c \
+	gb_proxy_tlli.c \
+	gb_proxy_peer.c \
+	$(NULL)
+osmo_gbproxy_LDADD = \
+	$(top_builddir)/src/gprs/gprs_gb_parse.o \
+	$(top_builddir)/src/gprs/gprs_llc_parse.o \
+	$(top_builddir)/src/gprs/crc24.o \
+	$(top_builddir)/src/gprs/gprs_utils.o \
+	$(LIBOSMOCORE_LIBS) \
+	$(LIBOSMOGSM_LIBS) \
+	$(LIBOSMOVTY_LIBS) \
+	$(LIBOSMOCTRL_LIBS) \
+	$(LIBOSMOGB_LIBS) \
+	$(LIBGTP_LIBS) \
+	-lrt \
+	$(NULL)
diff --git a/src/gprs/gb_proxy.c b/src/gbproxy/gb_proxy.c
similarity index 100%
rename from src/gprs/gb_proxy.c
rename to src/gbproxy/gb_proxy.c
diff --git a/src/gprs/gb_proxy_ctrl.c b/src/gbproxy/gb_proxy_ctrl.c
similarity index 100%
rename from src/gprs/gb_proxy_ctrl.c
rename to src/gbproxy/gb_proxy_ctrl.c
diff --git a/src/gprs/gb_proxy_main.c b/src/gbproxy/gb_proxy_main.c
similarity index 100%
rename from src/gprs/gb_proxy_main.c
rename to src/gbproxy/gb_proxy_main.c
diff --git a/src/gprs/gb_proxy_patch.c b/src/gbproxy/gb_proxy_patch.c
similarity index 100%
rename from src/gprs/gb_proxy_patch.c
rename to src/gbproxy/gb_proxy_patch.c
diff --git a/src/gprs/gb_proxy_peer.c b/src/gbproxy/gb_proxy_peer.c
similarity index 100%
rename from src/gprs/gb_proxy_peer.c
rename to src/gbproxy/gb_proxy_peer.c
diff --git a/src/gprs/gb_proxy_tlli.c b/src/gbproxy/gb_proxy_tlli.c
similarity index 100%
rename from src/gprs/gb_proxy_tlli.c
rename to src/gbproxy/gb_proxy_tlli.c
diff --git a/src/gprs/gb_proxy_vty.c b/src/gbproxy/gb_proxy_vty.c
similarity index 100%
rename from src/gprs/gb_proxy_vty.c
rename to src/gbproxy/gb_proxy_vty.c
diff --git a/src/gprs/Makefile.am b/src/gprs/Makefile.am
index e6144f4..e951004 100644
--- a/src/gprs/Makefile.am
+++ b/src/gprs/Makefile.am
@@ -57,26 +57,10 @@
 	$(NULL)
 
 bin_PROGRAMS = \
-	osmo-gbproxy \
 	osmo-sgsn \
 	osmo-gtphub \
 	$(NULL)
 
-osmo_gbproxy_SOURCES = \
-	gb_proxy.c \
-	gb_proxy_main.c \
-	gb_proxy_vty.c \
-	gb_proxy_ctrl.c \
-	gb_proxy_patch.c \
-	gb_proxy_tlli.c \
-	gb_proxy_peer.c \
-	$(NULL)
-osmo_gbproxy_LDADD = \
-	libcommon.la \
-	$(OSMO_LIBS) \
-	-lrt \
-	$(NULL)
-
 osmo_sgsn_SOURCES = \
 	gprs_gb.c \
 	gprs_gmm_attach.c \
diff --git a/tests/gbproxy/Makefile.am b/tests/gbproxy/Makefile.am
index ef38fb6..cb245b4 100644
--- a/tests/gbproxy/Makefile.am
+++ b/tests/gbproxy/Makefile.am
@@ -32,10 +32,10 @@
 	$(NULL)
 
 gbproxy_test_LDADD = \
-	$(top_builddir)/src/gprs/gb_proxy.o \
-	$(top_builddir)/src/gprs/gb_proxy_patch.o \
-	$(top_builddir)/src/gprs/gb_proxy_peer.o \
-	$(top_builddir)/src/gprs/gb_proxy_tlli.o \
+	$(top_builddir)/src/gbproxy/gb_proxy.o \
+	$(top_builddir)/src/gbproxy/gb_proxy_patch.o \
+	$(top_builddir)/src/gbproxy/gb_proxy_peer.o \
+	$(top_builddir)/src/gbproxy/gb_proxy_tlli.o \
 	$(top_builddir)/src/gprs/gprs_gb_parse.o \
 	$(top_builddir)/src/gprs/gprs_llc_parse.o \
 	$(top_builddir)/src/gprs/crc24.o \
diff --git a/tests/vty_test_runner.py b/tests/vty_test_runner.py
index 19eaf28..a71865d 100755
--- a/tests/vty_test_runner.py
+++ b/tests/vty_test_runner.py
@@ -71,11 +71,11 @@
 class TestVTYGbproxy(TestVTYBase):
 
     def vty_command(self):
-        return ["./src/gprs/osmo-gbproxy", "-c",
+        return ["./src/gbproxy/osmo-gbproxy", "-c",
                 "doc/examples/osmo-gbproxy/osmo-gbproxy.cfg"]
 
     def vty_app(self):
-        return (4246, "./src/gprs/osmo-gbproxy", "OsmoGbProxy", "gbproxy")
+        return (4246, "./src/gbproxy/osmo-gbproxy", "OsmoGbProxy", "gbproxy")
 
     def testVtyTree(self):
         self.vty.enable()
@@ -277,7 +277,7 @@
             self.assertTrue(self.vty.verify('timer t%d 10' % t, ['']))
 
 def add_gbproxy_test(suite, workdir):
-    if not os.path.isfile(os.path.join(workdir, "src/gprs/osmo-gbproxy")):
+    if not os.path.isfile(os.path.join(workdir, "src/gbproxy/osmo-gbproxy")):
         print("Skipping the Gb-Proxy test")
         return
     test = unittest.TestLoader().loadTestsFromTestCase(TestVTYGbproxy)

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/15361
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-Change-Id: I2cc98d3a276d953609bbbbaa9782a0112687791e
Gerrit-Change-Number: 15361
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190830/6fdd34ec/attachment.html>


More information about the gerrit-log mailing list