Change in ...osmo-ggsn[master]: cosmetic: gtp: Drop commented out code calling pdp_freepdp()

laforge gerrit-no-reply at lists.osmocom.org
Fri Aug 30 15:59:24 UTC 2019


laforge has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/15322 )

Change subject: cosmetic: gtp: Drop commented out code calling pdp_freepdp()
......................................................................

cosmetic: gtp: Drop commented out code calling pdp_freepdp()

That code was commented out in 0b076a331e1e7f955580313a5da416c170b3b4ce
(year 2003), and indeed it makes no sense to call those in current pdp
lifecycle (they are expected to be freed by the application).

Change-Id: I096d8cb8d749ff9b737d6f3f96b1d423660ece37
---
M gtp/gtp.c
1 file changed, 0 insertions(+), 26 deletions(-)

Approvals:
  Jenkins Builder: Verified
  laforge: Looks good to me, approved



diff --git a/gtp/gtp.c b/gtp/gtp.c
index 2ea949d..ba248c6 100644
--- a/gtp/gtp.c
+++ b/gtp/gtp.c
@@ -1752,8 +1752,6 @@
 			    "Invalid message format\n");
 		if (gsn->cb_conf)
 			gsn->cb_conf(type, EOF, pdp, cbp);
-		/*    if (gsn->cb_delete_context) gsn->cb_delete_context(pdp);
-		   pdp_freepdp(pdp); */
 		return EOF;
 	}
 
@@ -1764,8 +1762,6 @@
 			    "Missing mandatory information field\n");
 		if (gsn->cb_conf)
 			gsn->cb_conf(type, EOF, pdp, cbp);
-		/*    if (gsn->cb_delete_context) gsn->cb_delete_context(pdp);
-		   pdp_freepdp(pdp); */
 		return EOF;
 	}
 
@@ -1792,8 +1788,6 @@
 					    "Missing conditional information field\n");
 				if (gsn->cb_conf)
 					gsn->cb_conf(type, EOF, pdp, cbp);
-				/*    if (gsn->cb_delete_context) gsn->cb_delete_context(pdp);
-				   pdp_freepdp(pdp); */
 				return EOF;
 			}
 		}
@@ -1805,8 +1799,6 @@
 				    "Missing conditional information field\n");
 			if (gsn->cb_conf)
 				gsn->cb_conf(type, EOF, pdp, cbp);
-			/*    if (gsn->cb_delete_context) gsn->cb_delete_context(pdp);
-			   pdp_freepdp(pdp); */
 			return EOF;
 		}
 
@@ -1818,8 +1810,6 @@
 					    "Missing conditional information field\n");
 				if (gsn->cb_conf)
 					gsn->cb_conf(type, EOF, pdp, cbp);
-				/*    if (gsn->cb_delete_context) gsn->cb_delete_context(pdp);
-				   pdp_freepdp(pdp); */
 				return EOF;
 			}
 
@@ -1830,8 +1820,6 @@
 					    "Missing conditional information field\n");
 				if (gsn->cb_conf)
 					gsn->cb_conf(type, EOF, pdp, cbp);
-				/*    if (gsn->cb_delete_context) gsn->cb_delete_context(pdp);
-				   pdp_freepdp(pdp); */
 				return EOF;
 			}
 		}
@@ -1844,8 +1832,6 @@
 					    "Missing conditional information field\n");
 				if (gsn->cb_conf)
 					gsn->cb_conf(type, EOF, pdp, cbp);
-				/*    if (gsn->cb_delete_context) gsn->cb_delete_context(pdp);
-				   pdp_freepdp(pdp); */
 				return EOF;
 			}
 
@@ -1856,8 +1842,6 @@
 					    "Missing conditional information field\n");
 				if (gsn->cb_conf)
 					gsn->cb_conf(type, EOF, pdp, cbp);
-				/*    if (gsn->cb_delete_context) gsn->cb_delete_context(pdp);
-				   pdp_freepdp(pdp); */
 				return EOF;
 			}
 		}
@@ -1869,8 +1853,6 @@
 				    "Missing conditional information field\n");
 			if (gsn->cb_conf)
 				gsn->cb_conf(type, EOF, pdp, cbp);
-			/*    if (gsn->cb_delete_context) gsn->cb_delete_context(pdp);
-			   pdp_freepdp(pdp); */
 		}
 
 		if (gtpie_gettlv(ie, GTPIE_EUA, 0, &pdp->eua.l,
@@ -1881,8 +1863,6 @@
 				    "Missing conditional information field\n");
 			if (gsn->cb_conf)
 				gsn->cb_conf(type, EOF, pdp, cbp);
-			/*    if (gsn->cb_delete_context) gsn->cb_delete_context(pdp);
-			   pdp_freepdp(pdp); */
 			return EOF;
 		}
 
@@ -1894,8 +1874,6 @@
 				    "Missing conditional information field\n");
 			if (gsn->cb_conf)
 				gsn->cb_conf(type, EOF, pdp, cbp);
-			/*    if (gsn->cb_delete_context) gsn->cb_delete_context(pdp);
-			   pdp_freepdp(pdp); */
 			return EOF;
 		}
 
@@ -1907,8 +1885,6 @@
 				    "Missing conditional information field\n");
 			if (gsn->cb_conf)
 				gsn->cb_conf(type, EOF, pdp, cbp);
-			/*    if (gsn->cb_delete_context) gsn->cb_delete_context(pdp);
-			   pdp_freepdp(pdp); */
 			return EOF;
 		}
 
@@ -1922,8 +1898,6 @@
 					    "Missing conditional information field\n");
 				if (gsn->cb_conf)
 					gsn->cb_conf(type, EOF, pdp, cbp);
-				/*    if (gsn->cb_delete_context) gsn->cb_delete_context(pdp);
-				   pdp_freepdp(pdp); */
 				return EOF;
 			}
 		}

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-ggsn/+/15322
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ggsn
Gerrit-Branch: master
Gerrit-Change-Id: I096d8cb8d749ff9b737d6f3f96b1d423660ece37
Gerrit-Change-Number: 15322
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at gnumonks.org>
Gerrit-Reviewer: lynxis lazus <lynxis at fe80.eu>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190830/de3aa43a/attachment.html>


More information about the gerrit-log mailing list