Change in ...osmo-sgsn[master]: Merge common allocation steps for Gb and Iu ctx

pespin gerrit-no-reply at lists.osmocom.org
Fri Aug 30 10:29:42 UTC 2019


pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/15338 )

Change subject: Merge common allocation steps for Gb and Iu ctx
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/#/c/15338/1/src/gprs/gprs_sgsn.c 
File src/gprs/gprs_sgsn.c:

https://gerrit.osmocom.org/#/c/15338/1/src/gprs/gprs_sgsn.c@a244 
PS1, Line 244: 
> Unrelated.
That cannot be unrelated, It's a new function, and this one was heavily rewritten. Please don't look line to line but commit-wise (I know it's difficult with commits refactoring code).



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/15338
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-Change-Id: Ib6c0427ac7b35295cf1caf2f28cb2a5c155b9d9c
Gerrit-Change-Number: 15338
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <axilirator at gmail.com>
Gerrit-Reviewer: laforge <laforge at gnumonks.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Fri, 30 Aug 2019 10:29:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <axilirator at gmail.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190830/33358d70/attachment.html>


More information about the gerrit-log mailing list