Change in ...osmo-sgsn[master]: Split enum gprs_pmm_state into Iu and Gb counterparts

pespin gerrit-no-reply at lists.osmocom.org
Fri Aug 30 10:27:53 UTC 2019


pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/15337 )

Change subject: Split enum gprs_pmm_state into Iu and Gb counterparts
......................................................................


Patch Set 1:

(4 comments)

https://gerrit.osmocom.org/#/c/15337/1/src/gprs/gprs_gmm.c 
File src/gprs/gprs_gmm.c:

https://gerrit.osmocom.org/#/c/15337/1/src/gprs/gprs_gmm.c@113 
PS1, Line 113: MM_IDLE
> Looks like a copy-paste error to me, as 'gprs_mm_state_iu' enum defines different states (than 'gprs […]
Good catch, thanks!


https://gerrit.osmocom.org/#/c/15337/1/src/gprs/gprs_gmm.c@181 
PS1, Line 181: mmctx_set_pmm_state
> Same problem with naming, maybe we should also use '_iu_' / '_gb_' prefixes here?
That's going to get replaced soon anyway with FSMs, so, I didn't want to make this commit even more complex changing names which will be dropped anyway.


https://gerrit.osmocom.org/#/c/15337/1/src/gprs/gprs_gmm.c@199 
PS1, Line 199: case PMM_DETACHED:
> This change looks unrelated, but in general I am not against it.
It's not unrelated. It's related to the fact that now we have only 3 fields in the enum. But yes, you can always argument whether it should go together or not.


https://gerrit.osmocom.org/#/c/15337/1/src/gprs/gprs_gmm.c@215 
PS1, Line 215: gprs_mm_state_iu_names
> Looks like a mistake to me.
Indeed, thanks!



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/15337
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-Change-Id: I6100d607da316da0595886c6968704dd9ccfbde9
Gerrit-Change-Number: 15337
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <axilirator at gmail.com>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-CC: laforge <laforge at gnumonks.org>
Gerrit-Comment-Date: Fri, 30 Aug 2019 10:27:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <axilirator at gmail.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190830/234260a5/attachment.html>


More information about the gerrit-log mailing list