Change in ...osmo-sgsn[master]: sgsn: gtp: Drop related pdp contexts on echo timeout against GGSN

pespin gerrit-no-reply at lists.osmocom.org
Fri Aug 30 10:11:44 UTC 2019


pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/15308 )

Change subject: sgsn: gtp: Drop related pdp contexts on echo timeout against GGSN
......................................................................


Patch Set 2:

(1 comment)

https://gerrit.osmocom.org/#/c/15308/2/src/gprs/sgsn_libgtp.c 
File src/gprs/sgsn_libgtp.c:

https://gerrit.osmocom.org/#/c/15308/2/src/gprs/sgsn_libgtp.c@589 
PS2, Line 589: sgsn_ggsn_ctx_drop_all_pdp
> This one seems to be the key change of this commit, while the others: […]
Yes, they could be made separate, but tbh I prefer keeping them together since they are related, since they are improving related code to add the feature.

It's basically rewriting echo_conf to do something useful with it.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/15308
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-Change-Id: I7e97bac1c13a2c26203eb64e590fd75d77eb44bd
Gerrit-Change-Number: 15308
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-CC: fixeria <axilirator at gmail.com>
Gerrit-Comment-Date: Fri, 30 Aug 2019 10:11:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <axilirator at gmail.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190830/934465c8/attachment.html>


More information about the gerrit-log mailing list