Change in ...osmo-sgsn[master]: Introduce log helper LOGGGSN

laforge gerrit-no-reply at lists.osmocom.org
Fri Aug 30 08:24:01 UTC 2019


laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/15307 )

Change subject: Introduce log helper LOGGGSN
......................................................................


Patch Set 2:

(1 comment)

https://gerrit.osmocom.org/#/c/15307/2/include/osmocom/sgsn/gprs_sgsn.h 
File include/osmocom/sgsn/gprs_sgsn.h:

https://gerrit.osmocom.org/#/c/15307/2/include/osmocom/sgsn/gprs_sgsn.h@411 
PS2, Line 411: ggc->id
it's customary to use (ggc)->id in such macros, as you don't know how exactly somebody provides the argument



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/15307
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-Change-Id: I30f46f44af1d0eee324b1a995c1dad2e1315af7c
Gerrit-Change-Number: 15307
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: fixeria <axilirator at gmail.com>
Gerrit-CC: laforge <laforge at gnumonks.org>
Gerrit-Comment-Date: Fri, 30 Aug 2019 08:24:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190830/a10facd0/attachment.html>


More information about the gerrit-log mailing list