Change in ...osmocom-bb[master]: trx_toolkit/data_msg.py: also print burst length in desc_hdr()

pespin gerrit-no-reply at lists.osmocom.org
Thu Aug 29 13:59:58 UTC 2019


pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/15333 )

Change subject: trx_toolkit/data_msg.py: also print burst length in desc_hdr()
......................................................................


Patch Set 1:

(2 comments)

https://gerrit.osmocom.org/#/c/15333/1/src/target/trx_toolkit/data_msg.py 
File src/target/trx_toolkit/data_msg.py:

https://gerrit.osmocom.org/#/c/15333/1/src/target/trx_toolkit/data_msg.py@185 
PS1, Line 185: 		if type(self.burst) is list and len(self.burst) > 0:
Why type(self.burst) is list? how can it be different? "self.burst is not None"?


https://gerrit.osmocom.org/#/c/15333/1/src/target/trx_toolkit/data_msg.py@186 
PS1, Line 186: 			result += ("bl=%u " % len(self.burst))
May be worth precaching len(self.burst), I don't know if python lists have precached len.



-- 
To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/15333
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Change-Id: Ia0036cbf70a3736a7f9779e030e05221cba8add9
Gerrit-Change-Number: 15333
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <axilirator at gmail.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Thu, 29 Aug 2019 13:59:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190829/64d6692b/attachment.html>


More information about the gerrit-log mailing list