Change in ...osmo-bts[master]: pcu_sock: fix endian-swapped CellID

pespin gerrit-no-reply at
Thu Aug 29 12:57:13 UTC 2019

pespin has posted comments on this change. ( )

Change subject: pcu_sock: fix endian-swapped CellID

Patch Set 1: Code-Review-1

Commit Message: 
PS1, Line 14: to OsmoBTS, then with a socket to OsmoPCU. OsmoBTS was always sending
"the CellID is configured in OsmoBSC, sent via RSL to OsmoBTS" -> as BE.

"OsmoBTS was always sending the swapped CellID to OsmoPCU" -> meaning it's sending a BE integer over a unix socket in a LE system(wrong!)? Or swapping the value before sending it over the unix socket (correct)?

"In March 2018, a regression in OsmoPCU ([1]) caused it to swap the CellID again" -> What do you mean with "spaw" here? moved in code? because I see it moves the line but still uses ntohs().

"This regression was fixed in March 2019 ([2])." -> Ok, here cellID coming from unix socket is handled as LE on a LE system, fine.

Please rework the commit description so it's clear what you mean. 
File src/common/pcu_sock.c: 
PS1, Line 262: 		bts->cell_identity = ntohs(si3->cell_identity);
So here we are again handling a BE integer coming from a unix socket (intra-host)? Why? I'd expect to receive a host endianess integer here.

To view, visit
To unsubscribe, or for help writing mail filters, visit

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I68faf4558f0686fb2a3db24077dceaae05bf0262
Gerrit-Change-Number: 15326
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith at>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <axilirator at>
Gerrit-Reviewer: neels <nhofmeyr at>
Gerrit-Reviewer: osmith <osmith at>
Gerrit-Reviewer: pespin <pespin at>
Gerrit-Comment-Date: Thu, 29 Aug 2019 12:57:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <>

More information about the gerrit-log mailing list