Change in ...osmo-msc[master]: fix error on BSSMAP Cipher Mode Complete L3 msg IE

fixeria gerrit-no-reply at lists.osmocom.org
Thu Aug 29 12:32:36 UTC 2019


fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/15317 )

Change subject: fix error on BSSMAP Cipher Mode Complete L3 msg IE
......................................................................


Patch Set 3:

(1 comment)

https://gerrit.osmocom.org/#/c/15317/3/src/libmsc/msc_a.c 
File src/libmsc/msc_a.c:

https://gerrit.osmocom.org/#/c/15317/3/src/libmsc/msc_a.c@1411 
PS3, Line 1411: but this static msgb saves the extra allocation
> I'm really not sure if this is the right approach. […]
ACK. This approach wouldn't be that dangerous if all DTAP-handling functions were accepting 'const struct msgb *', so we could be sure that nobody calls msgb_free(). But they don't.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/15317
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: Icd8dad18d6dda24d075dd8da72c3d6db1302090d
Gerrit-Change-Number: 15317
Gerrit-PatchSet: 3
Gerrit-Owner: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: fixeria <axilirator at gmail.com>
Gerrit-CC: laforge <laforge at gnumonks.org>
Gerrit-Comment-Date: Thu, 29 Aug 2019 12:32:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <laforge at gnumonks.org>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190829/849172d5/attachment.html>


More information about the gerrit-log mailing list