This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
pespin gerrit-no-reply at lists.osmocom.orgpespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/15324 Change subject: ggsn: rx DeletePdpReq confirmation: Improve documentation and use gtp_freepdp() ...................................................................... ggsn: rx DeletePdpReq confirmation: Improve documentation and use gtp_freepdp() Update documentation since nowadays there are more paths calling ggsn_close_one_pdp() (because we now close pdp contexts during sgsn timeouts). Switch pdp_freepdp() to gtp_freepdp() since in the event we ended up there in the future we want to go through normal delete_ctx_cb to free related application data structures. Change-Id: I7d9ae9a27390498ba387797aac6651e32fa44f29 --- M ggsn/ggsn.c 1 file changed, 10 insertions(+), 9 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ggsn refs/changes/24/15324/1 diff --git a/ggsn/ggsn.c b/ggsn/ggsn.c index 7b32bde..ffa508b 100644 --- a/ggsn/ggsn.c +++ b/ggsn/ggsn.c @@ -775,16 +775,17 @@ case GTP_DELETE_PDP_REQ: /* Remark: We actually never reach this path nowadays because only place where we call gtp_delete_context_req2() is during - apn_stop()->pool_close_all_pdp() path, and in that case we - free all pdp contexts immediatelly without waiting for - confirmation since we want to tear down the whole APN - anyways. As a result, DeleteCtxResponse will never reach here - since it will be dropped at some point in lower layers in the - Rx path. This code is nevertheless left here in order to ease - future developent and avoid possible future memleaks once more - scenarios where GGSN sends a DeleteCtxRequest are introduced. */ + ggsn_close_one_pdp() path, and in that case we free all pdp + contexts immediatelly without waiting for confirmation + (through gtp_freepdp_teardown()) since we want to tear down + the whole APN anyways. As a result, DeleteCtxResponse will + never reach here since it will be dropped at some point in + lower layers in the Rx path. This code is nevertheless left + here in order to ease future developent and avoid possible + future memleaks once more scenarios where GGSN sends a + DeleteCtxRequest are introduced. */ if (pdp) - rc = pdp_freepdp(pdp); + rc = gtp_freepdp(pdp->gsn, pdp); break; case GTP_ECHO_REQ: sgsn = (struct sgsn_peer *)cbp; -- To view, visit https://gerrit.osmocom.org/c/osmo-ggsn/+/15324 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ggsn Gerrit-Branch: master Gerrit-Change-Id: I7d9ae9a27390498ba387797aac6651e32fa44f29 Gerrit-Change-Number: 15324 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin at sysmocom.de> Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190829/01f1e8d1/attachment.htm>