Change in ...osmo-sip-connector[master]: mncc: check fd before closing a connection

pespin gerrit-no-reply at lists.osmocom.org
Thu Aug 29 09:49:31 UTC 2019


pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sip-connector/+/15303 )

Change subject: mncc: check fd before closing a connection
......................................................................


Patch Set 4:

(2 comments)

https://gerrit.osmocom.org/#/c/15303/4/src/mncc.c 
File src/mncc.c:

https://gerrit.osmocom.org/#/c/15303/4/src/mncc.c@327 
PS4, Line 327: 	if (conn->fd.fd < 0)
Would be great knowing why is close_connection() being called twice. Why is someone calling close_connection on an already close connection (delaying again the reconnect timer by 5 seconds in the future).


https://gerrit.osmocom.org/#/c/15303/4/src/mncc.c@332 
PS4, Line 332: 	conn->fd.fd = -1;
Did you make sure upon allocation this fd is set to NULL? otherwise you'd be calling close(0) or whatever value, and that's probably something we want to avoid.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-sip-connector/+/15303
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-sip-connector
Gerrit-Branch: master
Gerrit-Change-Id: I9742f31a37296fed15d54cf44c1f65b93abb8c8e
Gerrit-Change-Number: 15303
Gerrit-PatchSet: 4
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de>
Gerrit-CC: laforge <laforge at gnumonks.org>
Gerrit-CC: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Thu, 29 Aug 2019 09:49:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190829/7dd4cfb0/attachment.html>


More information about the gerrit-log mailing list